[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: gw6c on kfreebsd



Hi.

I got a new package, gw6c, into the archive.  I noticed the kfreebsd buildd died
https://buildd.debian.org/fetch.cgi?&pkg=gw6c&ver=6.0.1dfsg.1-2&arch=kfreebsd-amd64&stamp=1249531884&file=log

1) In debian/rules, you are already setting platform in some $(MAKE)
   invocations, currently it is hardcoded as linux. Please alter it as
   shown bellow.

2) please enhance debian/patches/10_directories.dpatch also for
   files in tspc-advanced/platform/freebsd/ directory

3) the remaining problem is devname() function. It will be available
   from eglibc 2.10 (hopefully soon), in mean time you can change

     unsafe_buffer = devname(sbuf.st_rdev, S_IFCHR);
     strncpy( name, unsafe_buffer, name_len );

   into

     dev_t dev = sbuf.st_rdev;
     sysctlbyname("kern.devname", name, &name_len, &dev, sizeof (dev));


Thanks for your care about GNU/kFreeBSD.

Petr


diff -u gw6c-6.0.1dfsg.1/debian/rules gw6c-6.0.1dfsg.1/debian/rules
--- gw6c-6.0.1dfsg.1/debian/rules
+++ gw6c-6.0.1dfsg.1/debian/rules
@@ -13,6 +13,16 @@

 include /usr/share/dpatch/dpatch.make

+export DEB_HOST_ARCH_OS ?= $(shell dpkg-architecture -qDEB_HOST_ARCH_OS)
+
+ifeq ($(DEB_HOST_ARCH_OS),kfreebsd)
+PLATFORM=freebsd
+endif
+ifeq ($(DEB_HOST_ARCH_OS),linux)
+PLATFORM=linux
+endif
+
+
 configure: configure-stamp
 configure-stamp:
        dh_testdir
@@ -27,8 +37,7 @@
        dh_testdir

        # Add here commands to compile the package.
-       #cd tspc-advanced && $(MAKE) all target=linux installdir=/usr/share/gw6c
-       $(MAKE) all target=linux installdir=/usr/share/gw6c
+       platform=$(PLATFORM) $(MAKE) all installdir=/usr/share/gw6c
        touch $@

 clean: unpatch
@@ -37,10 +46,7 @@
        rm -f build-stamp configure-stamp

        # Add here commands to clean up after the build process.
-       #$(MAKE) -C tspc-advanced clean target=linux
-       #$(MAKE) -C gw6c-config clean target=linux
-       #$(MAKE) -C gw6c-messaging clean target=linux
-       $(MAKE) clean
+       platform=$(PLATFORM) $(MAKE) clean
        -rm tspc-advanced/conf/gw6c.conf.sample

        dh_clean
@@ -52,7 +58,7 @@
        dh_installdirs

        # Add here commands to install the package into debian/gw6c.
-       $(MAKE) -C tspc-advanced/conf gw6c.conf.sample target=linux installdir=/usr/share/gw6c BIN_DIR=.
+       platform=$(PLATFORM) $(MAKE) -C tspc-advanced/conf gw6c.conf.sample installdir=/usr/share/gw6c BIN_DIR=.


 # Build architecture-independent files here.


Reply to: