Re: [patch] wine and jack-audio-connection-kit build problem

[Petr Salinger <Petr.Salinger@seznam.cz>]

Hi.

In fact, alternate patch for jack-audio-connection-kit
is since Mon, 29 Dec 2008 in #510127,
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=510127

The list of submitted entries should be available at

http://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=kfreebsd;users=glibc-bsd-devel@lists.alioth.debian.org;pri0=pending:pending,forwarded,pending-fixed,fixed,done,absent;ttl0=Outstanding,Forwarded,Pending%20Upload,Fixed%20in%20NMU,Resolved;pri1=pending%3dpending%2btag%3dwontfix,pending%3dpending%2btag%3dmoreinfo,pending%3dpending%2btag%3dpatch,pending%3dpending%2btag%3dconfirmed,pending%3dpending;ttl1=Will%20Not%20Fix,More%20information%20needed,Patch%20Available,Confirmed,Unclassified;ord1=2,3,4,1,0,5

It is up to debian/upstream maintainer whether and when they accept a patch :-(

Petr

On Tue, 6 Jan 2009, Luca Favatella wrote:

> Hi.
>
>
> Wine doesn't build on Debian GNU/KFreeBSD [wine buildd].
>
> The problem (at the moment) is that jack-audio-connection-kit doesn't
> build [jack buildd].
>
> Here are the interesting lines of the [jack buildd]:
> net_driver.c: In function 'net_driver_write':
> net_driver.c:499: error: 'MSG_CONFIRM' undeclared (first use in this function)
>
> Here are the interesting lines of net_driver.c (from [debian git jack]):
> 496 #ifdef __APPLE__
> 497         static const int flag = 0;
> 498 #else
> 499         static const int flag = MSG_CONFIRM;
> 500 #endif
>
> jackaudio upstream says it supports FreeBSD [jack homepage], but in
> these lines of net_driver.c it seems FreeBSD in not considered.
> In fact MSG_CONFIRM is linux specific [linux send(2) man page].
>
> FreeBSD has not this problem because they use a previous version
> [freebsd jack port], without this netjack feature [jack 0.115.6
> release notes].
>
>
> I propose a patch against the jack-audio-connection-kit package
> (suggested by [debian porting]).
> I think changing
> #ifdef __APPLE__
> to
> #if defined(__APPLE__) || defined(__FreeBSD__) || defined(__FreeBSD_kernel__)
> should solve the problem.
>
> I think this patch (or similar) should be pushed upstream because it
> is useful also for FreeBSD (when they'll update their port).
>
> Can you please consider applying this patch?
>
>
> Thanks,
> Luca Favatella
>
>
>
> [wine buildd]
> http://buildd.debian-ports.org/fetch.php?&pkg=wine&ver=1.1.9-1&arch=kfreebsd-i386&stamp=1231073161&file=log&as=raw
>
> [jack buildd]
> http://buildd.debian-ports.org/fetch.php?pkg=jack-audio-connection-kit&arch=kfreebsd-i386&ver=0.116.1-2&stamp=1230335159&file=log&as=raw
>
> [debian git jack]
> http://git.debian.org/?p=pkg-multimedia/jack-audio-connection-kit.git;a=blob;f=drivers/netjack/net_driver.c
>
> [jack homepage]
> http://jackaudio.org/
>
> [linux send(2) man page]
> http://www.kernel.org/doc/man-pages/online/pages/man2/sendmsg.2.html
>
> [freebsd jack port]
> http://www.freebsd.org/cgi/cvsweb.cgi/ports/audio/jack/
>
> [jack 0.115.6 release notes]
> http://jackaudio.org/node/19
>
> [debian porting]
> http://glibc-bsd.alioth.debian.org/porting/PORTING
>
>
> --
> To UNSUBSCRIBE, email to debian-bsd-REQUEST@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org