Re: __CONCAT
On Mon, Mar 20, 2006 at 11:04:52PM +0100, Petr Salinger wrote:
> > That isn't a good solution. The breakage is in kfreebsd-kernel-headers, which
> > expect the __CONCAT definition they obtain from <sys/cdefs.h> to be sane (and
> > __CONCAT is not really a bsdism; not currently at least).
>
> Unfortunately, the old and new behaviour will be
> different when applied on macros:
>
> #define __CONCAT1(x,y) x ## y
> #define __CONCATN(x,y) __CONCAT1(x,y)
>
> #define MYFUNC myfunc
>
> /* old one */
> __CONCAT1(OLD_, MYFUNC)
>
> /* new one */
> __CONCATN(OLD_, MYFUNC)
The old one expands to OLD_MYFUNC, which I don't think is very logical to what
the user would expect.. (as you mention on the bug)
> > We could try that.. But I don't know well the rationale behind this bug.
> > Would you like to file it?
>
> http://sourceware.org/bugzilla/show_bug.cgi?id=2471
k thanks.
--
Robert Millan
Reply to: