Bug#977877: marked as pending in console-setup
Control: tag -1 pending
Hello,
Bug #977877 in console-setup reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:
https://salsa.debian.org/installer-team/console-setup/-/commit/5347c879768c562a2ea6ca8ed92ea33c8d8b2c9e
------------------------------------------------------------------------
setupcon: use a fixed name for the initrd keymap file (closes: #977877)
Inspired by installer-team/console-setup!24, an MR from
Adithya Balakumar <Adithya.Balakumar@toshiba-tsip.com>
(from where most of this commit message comes)
Currently when using the --setup-dir option, a temp file(tmpkbd.*) is copied
to $SETUPDIR/etc/console-setup, But the filename is random due to use of
mktemp for the temp file creation.
This creates reproducibility issues due to different temp filenames across
multiple builds.
The temp file with the keymap information would be needed in the context of
loading the keymap file in the initrd stage.
Making the file name fixed while copying into $SETUPDIR/etc/console-setup
should not cause problems as the file created from the latest run of setupcon
will be referenced in the $SETUPDIR/bin/setupcon script.
This patch achieves that by extending tempfile() to be able to take a
filename, in which case mktemp is used to create a directory, and then
the passed-in filename is appended to that directory in order to give a
temporary name to use. Since the copying stage only uses the filename
part of the path, the non-determinism is no longer inserted into the
initrd.
------------------------------------------------------------------------
(this message was generated automatically)
--
Greetings
https://bugs.debian.org/977877
Reply to: