Chris Hofstaedtler <zeha@debian.org> writes:
> On Sun, Sep 07, 2025 at 12:19:58AM +0200, Philip Hands wrote:
[...]
>> The question that's still bothering me is:
>>
>> Does anything within the resulting initrd actually make use of the
>> 'keymap.*' file, and if so, where?
>
> I'm not sure which file you mean now with 'keymap.*'.
Sorry, that was my dyslexia creeping in there -- I meant to type
'tmpkbd.*'
> But all commands that setupcon would run are also copied into the
> built-setupcon (including some patching of referenced filenames).
To put that another way, the patch is about looking for files that match
"^tmpkbd\." and removing everything after the '.' and using what's left
as the filename in the initrd. (which AFAICS is bound to be "tmpkbd"
isn't it? so no need for sed)
The string 'tmpkbd' only appears twice in all the code that
codesearch.debian.net is able to search, and both those places are in
this script, as a parameter to mktemp, to populate $TMPFILE.
https://codesearch.debian.net/search?q=tmpkbd&literal=1
That being the case, where is the thing that is going to make use of the
file in question, with either name?
If (as it seems) the file we're messing about with is not used, wouldn't
it be simpler to not bother adding it to the initrd at all?
Even if this rename is required (given that it looks like the sed always
results in 'tmpkbd') we can make it more obvious what's going on. e.g.:
=-=-=-=
if [ "$f" != "${f#tmpkbd.}" ] ; then
f=tmpkbd
fi
=-=-=-=
If we knew why we were putting it there, we could give it a more
informative name than 'tmpkbd', but I'm yet to understand the
justification.
Cheers, Phil.
--
Philip Hands -- https://hands.com/~phil
Attachment:
signature.asc
Description: PGP signature