On 20/08/2025 à 11:51, Holger Wansing wrote:
Nit-picking: As the size input parsing is implemented in partman-base, shouldn't the associated text be defined there instead of duplicating it in each package which uses it ?I cannot find any duplication of the relevant string in other packages. The original bugreport mentions two message strings, and they are in different packages, but they are not identical, so no duplication.
This is part of the issue. Supported and default size units are defined in partman-base and independent message strings advertising them are defined in partman-lvm and partman-partitioning templates. IMO this design is sub-optimal and prone to inconsistencies:
- partman-lvm template advertises supported units and the default unit.- partman-partitioning template only advertises the most common supported units and not the default unit. - When support of binary units was added in partman-base, partman-lvm and partman-partitioning templates had to be updated to reflect it. - Support of P(i)B and E(i)B was added to partman-base at the same time but partman-lvm was not updated to reflect it. - When the default unit was changed to GB in partman-base, partman-lvm template was not updated to reflect it.
I do not expect other changes in this area any time soon so my comment is probably coming too late, but IMO a better design would have been to define the message string advertising the supported and default units in partman-base templates, and insert it with db_subst in message strings of other partman-* packages which need to display them.