[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#977877: console-setup: setupcon --setup-dir ... generates temporary file name inside etc/console-setup directory



On Sat, 15 Feb 2025 14:18:11 +0200 Anton Zinoviev <anton@lml.bas.bg> wrote:
> On Thu, Feb 13, 2025 at 06:32:55AM +0000, Adithya.Balakumar@toshiba-tsip.com wrote:
> > 
> > Thanks for the feedback. Based on the idea above, I have attached a revised 
> > patch. Please have a look at the patch and let me know if you have any concerns.
> 
> The solution seem ok.  However, I might be overlooking something but it 
> seems to me that the commands
> 
> +                            filename=$(echo $f | sed 's/\..*//')
> +                            dest_filename=$filename.fixed
> 
> do not generate an immutable file name.

Hi,

Right now all temp files are created as "tmpkbd.XXXXXX" (See [1]). My idea was to retain the "tmpkbd" part and ignore the random part of the name. Hence I used the sed command to split the name at the "."
Do you suggest to keep an entirely different (consistent) name while copying the file?

[1] https://salsa.debian.org/installer-team/console-setup/-/blob/master/setupcon?ref_type=heads#L63

Thanks and Regards,
Adithya
> 
> Anton Zinoviev
> 
> 
> 


Reply to: