Re: New partition sizes in default recipes for d-i
Hi,
Pascal Hambourg <pascal@plouf.fr.eu.org> wrote (Sun, 15 Sep 2024 14:39:42 +0200):
> On 15/09/2024 à 12:27, Holger Wansing wrote:
> >
> > Using the "separate home+var+tmp" recipe under UEFI variant on a 10G disk
> > results in an error
> >
> > "Unable to satisfy all constraints on the partition"
> > "Failed to partition the selected disk. This probably happened because there
> > are too many (primary) partitions in the partition table."
> (...)
> > In the partitioning overview (screenshot 3) the /home partition is
> > missing, so this is the one which raises the error apparently.
>
> Also, the /tmp partition size (468MB) is lower that the minimum size
> defined in the EFI "multi" recipe (500MB). The minimum disk size for
> this recipe is 11768MB, so the recipe should not be available on a
> 10.7GB (10GiB) disk. I suspect you hit the same bug on an already
> partitioned disk as described in
> <https://lists.debian.org/debian-boot/2024/08/msg00151.html>.
>
> Summary: existing reusable partitions (efi and swap) minimum sizes may
> wrongly be ignored when calculating the required minimum disk size even
> when using an entire disk.
You are right. A test on a freshly generated qemu disk does not trigger
this bug. (In fact, this recipe is not provided at all.)
So this is indeed an 'reuse' issue.
> Last time I guess it did not trigger an error because /home could be
> created, athough with the wrong size. This time, there was no free space
> left to create /home at all.
>
> The bug already existed previously and is totally unrelated with the MR,
> it could be triggered with specific disk sizes. It just happened that
> 10GiB is such a specific size for the updated recipes.
> It cannot happen on a disk with no efi nor swap partitions.
>
> > Do we need to adjust the minimum disk size for this recipe maybe, or similar?
>
> The minimum disk size for a recipe is calculated automatically by
> summing up the minimum partition sizes in the recipe. Changing minimum
> partition sizes would just change the disk size which triggers the bug.
>
> You may want to try the fix I prepared but considered not essential
> (useful only on small disks with sizes close to the required minimum
> size). Who would be fool enough to use the multi recipe on a 10GB disk ?
You are of course right here. We cannot make it fool-proof for all and
every situation.
> <https://salsa.debian.org/pham/partman-auto/-/commits/choose_recipe-fixes?ref_type=heads>
Holger
--
Holger Wansing <hwansing@mailbox.org>
PGP-Fingerprint: 496A C6E8 1442 4B34 8508 3529 59F1 87CA 156E B076
Reply to: