Bug#1076952: [RFD] partman-auto: Update guided partitioning size limits for current and future needs
Hi,
Am 27. August 2024 23:46:41 MESZ schrieb Pascal Hambourg <pascal@plouf.fr.eu.org>:
>
>I suspect this is caused by the "reuse" feature. It allows to reuse existing partitions of the same type (biosgrub, efi, swap) as partitions defined in the recipe with the "reusemethod" flag instead of creating them when partitioning using the largest free space. But it seems it is used when checking the minimum size regardless of whether using the largest free space or a whole disk (same code path). I need to figure out how to disable it when using whole disks.
>
>By the way, the reuse feature does not check if an existing partition size is greater than or equal to the minimum size defined in the recipe. IMO it should. Also existing swap partitions should not be reused, or at least not forcefully formated, because it may belong to another system.
I would like to leave these for another discussion as well...
>>> This was my initial intent. I removed the lvmok flag (and /boot) from
>>> the small_disk recipe and expected it to be ignored when using LVM.
>>> Looking at partman-auto-lvm code more closely, it seems that the lvmok
>>> flag check happens only after calling choose_recipe. So I guess the
>>> check should be moved into choose_recipe (in partman-auto).
>>
>> Ok. I would propose to move such change into a separate discussion/
>> bug report. Putting onto my to-do list.
>
>Fine, but what do we do with the small_disk recipe now ?
What about simply activating it for LVM as well?
Not the natural choice for this sort of recipe - of course, but the easiest
one, and the recipe stays consistent with all the others (to be used for non-LVM and LVM).
Holger
--
Sent from /e/ OS on Fairphone3
Reply to: