[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1073169: marked as done (debootstrap: support working on a nodev filesystem (e.g. /tmp))

Your message dated Sat, 15 Jun 2024 10:34:36 +0000
with message-id <E1sIQk0-006YXG-76@fasolo.debian.org>
and subject line Bug#1073169: fixed in debootstrap 1.0.135
has caused the Debian Bug report #1073169,
regarding debootstrap: support working on a nodev filesystem (e.g. /tmp)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1073169: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1073169
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: debootstrap
Version: 1.0.134
Tags: patch
X-Debbugs-Cc: josch@debian.org
Control: affects -1 + src:genext2fs

Hi,

I tried running the genext2fs autopkgtest for the /usr-move bootstrap
upload and it failed rather early here while running debootstrap:

    Cannot install into target '/tmp/...' mounted with noexec or nodev

I thought Johannes fixed debootstrap to work without mknod via
https://salsa.debian.org/installer-team/debootstrap/-/merge_requests/109,
so why would it fail on nodev?

When you're root and on a nodev filesystem, mknod still works. What does
not work is writing to that device. Hence, the bind mounting code does
not come into effect here. That also leads us to a relatively obvious
solution: We can simply try writing to the created devices and perform
the bind mount dance if it does not.

I've prepared a patch for this.

Helmut

diff --minimal -Nru debootstrap-1.0.134/debian/changelog debootstrap-1.0.134+nmu1/debian/changelog
--- debootstrap-1.0.134/debian/changelog	2024-01-05 10:17:39.000000000 +0100
+++ debootstrap-1.0.134+nmu1/debian/changelog	2024-06-13 22:30:06.000000000 +0200
@@ -1,3 +1,10 @@
+debootstrap (1.0.134+nmu1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Support working with a nodev filesystem. (Closes: #-1)
+
+ -- Helmut Grohne <helmut@subdivi.de>  Thu, 13 Jun 2024 22:30:06 +0200
+
 debootstrap (1.0.134) unstable; urgency=medium
 
   [ Johannes Schauer Marin Rodrigues ]
diff --minimal -Nru debootstrap-1.0.134/functions debootstrap-1.0.134+nmu1/functions
--- debootstrap-1.0.134/functions	2024-01-05 10:07:32.000000000 +0100
+++ debootstrap-1.0.134+nmu1/functions	2024-06-13 14:18:14.000000000 +0200
@@ -1306,7 +1306,8 @@
 		touch "$TARGET/dev/console"
 		;;
 	    *)
-		if ! setup_devices_simple; then
+		if ! setup_devices_simple ||
+		   !  sh -c ': >"$1"' -- "$TARGET/dev/null" 2>/dev/null; then
 			setup_devices_bind
 		fi
 		;;
@@ -1836,13 +1837,10 @@
 		  lxc|lxc-libvirt|mmdebstrap-unshare)
 		    ;;
 		  *)
-		    if mknod "$1/test-dev-null" c 1 3 2>/dev/null; then
-			if ! echo test > "$1/test-dev-null"; then
-			    rm -f "$1/test-dev-null"
-			    return 1
-			fi
-		    else
-			# mknod failed. Try if bind-mounting works
+		    if ! mknod "$1/test-dev-null" c 1 3 2>/dev/null ||
+		       ! echo test > "$1/test-dev-null"; then
+			# mknod failed (e.g. user namespace) or writing failed
+			# (e.g. nodev). Try if bind-mounting works
 			touch "$1/test-dev-null"
 			if ! mount -o bind /dev/null "$1/test-dev-null"; then
 			    rm -f "$1/test-dev-null"

--- End Message ---
--- Begin Message --- 
Source: debootstrap
Source-Version: 1.0.135
Done: Luca Boccassi <bluca@debian.org>

We believe that the bug you reported is fixed in the latest version of
debootstrap, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1073169@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Luca Boccassi <bluca@debian.org> (supplier of updated debootstrap package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 15 Jun 2024 11:13:44 +0100
Source: debootstrap
Architecture: source
Version: 1.0.135
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Luca Boccassi <bluca@debian.org>
Closes: 1061820 1073169
Changes:
 debootstrap (1.0.135) unstable; urgency=medium
 .
   [ Ken Sharp ]
   * fix quoting to allow spaces in target directory (Closes: #1061820)
   * Use distro-info where possible
   * Remove superfluous symlinks
   * Use correct keyring and mirror for Ubuntu
   * Ubuntu: test for dpkg zstd support for Hirsute+
   * Update dependencies
   * Remove hardcoded HTTPS mirror and use inline substitution
 .
   [ Adrien Robert ]
   * fix: handling of DIRECT returned by Acquire::http:Proxy-Auto-Detect
 .
   [ Johannes Schauer Marin Rodrigues ]
   * debian/tests/debian-testing: test minbase, default and buildd variants
 .
   [ Helmut Grohne ]
   * make debootstrap work on filesystems mounted nodev (Closes: #1073169)
Checksums-Sha1:
 7ac8f991ae154a8a19d0acbb7599b9f16b398918 2053 debootstrap_1.0.135.dsc
 ee3d22be86bdcd96b9c441470242ed88acac666e 93295 debootstrap_1.0.135.tar.gz
 366d6f0e3dad354d3b5248e3444c602d58461cc9 6584 debootstrap_1.0.135_source.buildinfo
Checksums-Sha256:
 f4cf53b6eb7fa0ac9b6f20dad59a7dd1d293b71945d06e2f91b590acff56e02f 2053 debootstrap_1.0.135.dsc
 15dfc865e2954764b10b19cc3cc61ecd6c1ba931f8e411b669478b191d2acde7 93295 debootstrap_1.0.135.tar.gz
 7db206e85534788d80e75707d52af14d6b25ca8b95abbceb56ae0439e724f5d3 6584 debootstrap_1.0.135_source.buildinfo
Files:
 a48cf4a79529d7b343204a92762bf13e 2053 admin optional debootstrap_1.0.135.dsc
 c7229d2d8c809683f6dac09ad3564514 93295 admin optional debootstrap_1.0.135.tar.gz
 a8f669fae46739d9266ffdc5016af6af 6584 admin optional debootstrap_1.0.135_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEErCSqx93EIPGOymuRKGv37813JB4FAmZtaawRHGJsdWNhQGRl
Ymlhbi5vcmcACgkQKGv37813JB6e8xAAxX0EGNVeikKdK1KhlEFV1UQa5egT0oL9
Fnd8FEP8BtLP43cIrVnrxZvlcJWtZO3vU837Y4DoQ9uz0M8jP7FwHqMg0sKI3wHe
Rjbr1ZhZQeILXRuf/T+88jIwn3WytYC5nr4q66VKBZpWemhdFiADBpZpM+itd7Ea
fXdeJrV/32RW3hpkjqglmtUpycno+lCaQozhxrM6/DvIiyO/UNOUUYgRZikIVozY
04HA6G2axoh8xOudnDRkK7J0IbmkIy8vKBXZI11r1gXOGxo0yStgxxZg+2TJwwX5
5v0KGV76lx8me2kvB69ggzuVf8p933U+KJaCuutRhuWtf6nZAd5yq7GVuR9bWnnm
iu4u+aU9E+Czc0ZeKDM5YBoWCqD2pEdlR5pZNWSM70Dsms+DiraBVicJZ3iZdb4L
TRAuovhlpNqWBJ1f+EV863dka4+JAUDCUbcI4Hk1ooTe2v5nUe7dgkK60DNCJkQV
xt6hmuqJArpOVjM252CHUyp7EN2bdxuzAnf5ZTrXqPl78rhvhhBmkWBmIye+hA+T
08g3GrWgzatl6E3VC0RHYLKc2yuawQUNRuSkn8RsjaHbJHXoqoclEay0z3w4t9Mi
zBPtbWl7bfQdn6kEp7EZB5GA0MzxI3dkA8TJD4yJxsvrV6NJ9lzFwDb0bca+FSuL
rkPVaKE5mv4=
=Wa2q
-----END PGP SIGNATURE-----

Attachment: pgpdFMg28kuIT.pgp
Description: PGP signature


--- End Message ---
Reply to: