On Sunday, 30 April 2023 20:25:50 CEST James Addison wrote: > Do we _need_ to retain the vendor name and model name in the firmware > filename? > > My guess (without being too familiar with the firmware loading process yet) > is that it'd be easier to ship a concisely-named file that omit the vendor > and model strings, so we'd want a way to map: > > brcmfmac43455-sdio.Raspberry Pi Foundation-Raspberry Pi 4 Model B.txt > > To the corresponding, already-packaged[4] filename: > > brcmfmac43455-sdio.txt > > ...while preferably avoiding adding custom scripting for too many other > firmware filenames in future. Where does the long-format filename originate > from? I suggest we stick to `brcmfmac43455-sdio.raspberrypi,4-model-b.txt` as that is its name in the upstream repo: https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git > And a nitpick: the way this appears in the hw-detect prompt screen in the > installer is a bit odd, because spaces in the filenames are replaced with > newlines. That might be nice to fix at the same time if we can. AFAIC it's a bit more then a nitpick as it identified a/several bugs in the script. Run it through `shellcheck` and you'll see a whole bunch of*: SC2086 (info): Double quote to prevent globbing and word splitting. https://www.shellcheck.net/wiki/SC2086 And that's exactly what happens or will happen. Even though the RPi4 filename doesn't contain spaces, there are several in the `brcm` directory that do. I didn't check other directories, but I'd expect that filenames with a space is NOT an anomaly. *) and several other warnings/suggestions
Attachment:
signature.asc
Description: This is a digitally signed message part.