[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1033630: debian-installer: should fstab swap entries use "sw" as option?



Source: debian-installer
Version: 20230217
Severity: minor


Hey.

In the end this is probably anyway completely ignored, so consider this
just a cosmetic issue:


AFAICS, the installer cretes swap entries in fstab as:
<swap-device/file> none swap sw 0 0

https://salsa.debian.org/installer-team/partman-basicfilesystems/-/blob/master/fstab.d/basic#L32
and also at least there:
https://salsa.debian.org/installer-team/partman-swapfile/-/blob/master/finish.d/fstab_swapfile#L10

I wondered whether "sw" is still the "canonical" value for the 4th field.

fstab(5) describes the appropriate values for swap for fields 1 to 3
(inclusive).
But it gives nothing about the 4th.
Neither do e.g. the manpages mount(8) or swapon(8).

I briefly tried to track down where the "sw" actually came from, seems
it might be from BDS times?


Anyway... maybe it makes sense to use some other value, most likely
"defaults" then... or perhaps "auto,nouser"?
"defaults" would be a bit misleading as its documented to be:
       defaults
           use default options: rw, suid, dev, exec, auto, nouser, and async.
which most make no sense for swap.
So perhaps "auto,nouser" would be the most reasonable ones?


Alternatively, this should perhaps be reassigned to mount, with the request
that "sw" is documented somehow, and if it's just that it's ignored for
entries of type swap.
Sidenote: It doesn't seem as if the 4th field would be generally ignored
for swap, e.g. nofail, noauto are considered.


Cheers,
Chris.


Reply to: