Hi, Pascal Hambourg <pascal@plouf.fr.eu.org> (2023-03-16): > Package: src:hw-detect > Version: 1.155 > Tags: patch > > Dear maintainer, > Please consider merging the attached patches. > > - hw-detect.pre-pkgsel.d/50install-firmware: fix path of deleted file Can be considered. > - check-missing-firmware.sh: shift positional parameters after reading > -n > > - check-missing-firmware.sh: define local variables in functions The commit messages say what you do, not why. > - check-missing-firmware.sh: get package name from control instead of > file name Can be considered. > - check-missing-firmware.sh: replace spaces with tabs in indentation NACK. We have mixed tabs and spaces all over the place, in hw-detect and in other components. We don't need noise. Especially not at this stage. Cheers, -- Cyril Brulebois (kibi@debian.org) <https://debamax.com/> D-I release manager -- Release team member -- Freelance Consultant
Attachment:
signature.asc
Description: PGP signature