Bug#1030519: check-missing-firmware: patch for files with space characters, mediamount and more (with code)

Hi Cyril,

> Attaching patches is best done by using git diff / git format-patch.

sure, but this is an inconvenience for me as outside contributor and might deter other ones as well.

I'm sure you and other core maintainers can import one file with ease...

> Not a good idea, seeing iwlwifi requests 68 files…

Oh, nevermind ... I changed the format back to be space separated -> $(cat $files | tr '\n' ' ' | sed 's/.$//')

I did some further testing with different storage devices SD-Card / USB-Stick etc. and also noticed the issues described in #1029962.

Calling mountmedia; (without driver) only mounts the first 'mountable' device even when it's empty. Calling mountmedia driver; pics the first device with a *.deb, *.udeb or *.ude file on it.

To get both loose and deb files working reliably the mountmedia package has to be updated. There are also some other issues caused by this package like unnecessary double tries with 5 second sleep (-> long loading times), devices can appear in two lists (-> four mount tries) and unsuppressed error messages.

I basically copied and modified the core functionality as two new functions check_directory() and find_firmware() as drop in replacement for mountmedia.

tested and working fine and fast:

deb on USB-stick

loose files on USB-stick

deb on SD-card

loose files on SD-card

deb on Firmware partion of flashed netboot mini-ISO on USB-stick

loose files on Firmware partition of flashed netboot mini-ISO on USB-stick

notes:

"for filename in $(ls $dir/*.deb); do" in check_for_firmware() reverted back to "for filename in $dir/*.deb; do",

the one item "/cdrom/firmware/*.deb" returned is normal behaviour if nothing is found.

(e.g. due to wrong device mounted by mountmedia)

see attached file.

Am Sa., 4. Feb. 2023 um 16:15 Uhr schrieb Cyril Brulebois <kibi@debian.org>:

Control: tag -1 - d-i

Hi Alexander,

Alexander Dalm <a.dalm2807@googlemail.com> (2023-02-04):
> So, I build it with dpkg-deb like just like my driver packages:
[…]
> Can these steps be added to the Makefile or what is the proper way to build the hw-detect udep?

That's a Debian package, it's built with dpkg-buildpackage, just like
any other Debian package. That's why there's no specific information in
any Makefile, README, or wiki.

> I also found this link but I didn't tried it since the manual way works fine:
> https://wiki.debian.org/DebianInstaller/Modify/CD#Create_a_udeb_packages_file
>
> ---
>
> I will submit this file and a screenshot as attachment in a further
> information mail (instead of creating a Gitlab account) […]

Attaching patches is best done by using git diff / git format-patch.

> With my changes in check-missing-firmware files are displayed with
> line breaks in the graphical installer but the first file is still
> shown in the same line.

Not a good idea, seeing iwlwifi requests 68 files…

Cheers,
--
Cyril Brulebois (kibi@debian.org) <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant