[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1023472: Fix for double Window Manager in LXQt



On 22/01/2023 16:48, Holger Wansing wrote:
Hi,

Roland Clobus <rclobus@rclobus.nl> wrote (Sun, 22 Jan 2023 09:57:36 +0100):
... now sending to the bug, to show the full text ...

The proposed patch is at Salsa:
https://salsa.debian.org/installer-team/tasksel/-/merge_requests/23

By mentioning the sddm theme before sddm, it will prevent the default
theme of sddm to be installed.
Also in the MR: for some reason the theme was mentioned twice, it was
probably intended to allow for other sddm themes.

Your proposal


   Depends: ${misc:Depends},
            task-desktop,
+ # Mention the preferred theme before sddm, otherwise another theme will be used
+          sddm-theme-debian-elarun | sddm-theme,
            sddm,
-          sddm-theme-debian-elarun | sddm-theme-debian-elarun,
            lxqt,


will not work.
sddm-theme-debian-elarun itself recommends sddm, so installing
sddm-theme-debian-elarun will pull in sddm anyway, no matter what you do else.
And sddm pulls in most of the KDE environment, including kwin.

So I guess we will need to remove both, sddm-theme-debian-elarun and sddm,
from the list here, if we don't want kwin (and all the other KDE stuff).

Leaves us (or lxqt people, in CC) with the question, if some other theme package
is needed as a replacement from the above...

To test this, I've prepared a local version of tasksel with this change.
Then, by pushing the newer tasksel, tasksel-data, task-desktop and task-lxqt-desktop .deb files into the live image, I was able to generate a live image for LXQt with sddm-theme-debian-elarun as the only sddm theme. With the current tasksel 3.71, both sddm-theme-debian-elarun and sddm-theme-debian-breeze will get installed.
This MR solved the issue for me.

However, it might be that I've found a case where the resolving of dependencies by apt is not 100% deterministic...

sddm-theme-debian-elarun does not recommend sddm, it only suggests it.
In the default case of generating a live image (only depend and recommend is followed), this is sufficient to fulfil the recommends (sddm-theme-debian-breeze | sddm-theme) in sddm with sddm-theme-debian-elarun, which is mentioned earlier and therefore the second part of the or-statement will be met.

With kind regards,
Roland

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


Reply to: