Philip Hands <phil@hands.com> writes: ... > However, I am now wondering whether we might not be better off using > `archdetect` to see if we're on an efi system, and then make the attempt > to call mountvirtfs for the efivarfs conditional on that. After a diversion[1], I had a look at the archdetect option, and have discovered that this simple patch: https://salsa.debian.org/philh/grub-installer/-/commit/6f33bd183d7d0ced76958440534407dc9d0ad141 fixes the UEFI boot, without breaking the BIOS boot (on amd64 at least, while doing a minimal install): https://openqa.debian.net/tests/overview?version=testing&build=--20230820_1958_salsa&distri=debian I hope/assume that all the arches that need this have the good grace to return `efi` as their subarch. If there's any risk that's not the case, we could also apply the previous patch. If you want to do your own tests, the mini.iso can be downloaded via: https://salsa.debian.org/philh/grub-installer/-/jobs/4582667/artifacts/file/debian/output/debian-202306XX+salsaci+20230820+228-amd64-gtkmini.iso BTW that's in the artifacts of the `mini-ISO` job, which can be found by looking at the pipeline linked from the commit above[2], and looking to the right for the Downstream pipelines -- further right you can find links to the openQA jobs above. Cheers, Phil. [1] rewriting branch2repo so that it doesn't need a state repo. for many use-cases, which will hopefully allow anyone to run these D-I tests on salsa, without any special setup. [2] https://salsa.debian.org/philh/grub-installer/-/pipelines/567684 -- Philip Hands -- https://hands.com/~phil
Attachment:
signature.asc
Description: PGP signature