Re: Bug#1029843: Missing symlinks for RPi 4 (to brcmfmac43455-sdio.raspberrypi,4-model-b.txt)
On Mon, 8 May 2023 at 14:57, Diederik de Haas <didi.debian@cknow.org> wrote:
>
> On Monday, 8 May 2023 14:08:14 CEST James Addison wrote:
> > On Mon, 1 May 2023 11:18:03 +0100, James Addison <jay@jp-hosting.net> wrote:
> > > > Diederik de Haas <didi.debian@cknow.org> (2023-04-30):
> > > > > And that's exactly what happens or will happen. Even though the RPi4
> > > > > filename doesn't contain spaces, there are several in the `brcm`
> > > > > directory that do. I didn't check other directories, but I'd expect
> > > > > that filenames with a space is NOT an anomaly.
> > >
> > > Since more files with that pattern are appearing upstream in
> > > linux-firmware.. yes, slightly reluctantly it does seem that this will
> > > be needed.
> >
> > FWIW: After learn the root cause of the spaces-in-filenames problem for
> > packages derived from linux-firmware.git -- that is, the contents of the
> > 'WHENCE' file in linux-firmware.git -- in fact the RPi4 is the only
> > affected[1] firmware currently.
>
> Triggered by your statement, I did a VERY crude search for spaces
> in "File: " or "Link: " lines in the WHENCE file:
>
> diederik@bagend:~/dev/kernel.org/linux-firmware$ grep -E "^Link: .* .* -> .*" WHENCE
> Link: brcm/brcmfmac43455-sdio.Raspberry\ Pi\ Foundation-Raspberry\ Pi\ 4\ Model\ B.txt -> brcmfmac43455-sdio.raspberrypi,4-model-b.txt
> Link: brcm/brcmfmac43455-sdio.Raspberry\ Pi\ Foundation-Raspberry\ Pi\ Compute\ Module\ 4.txt -> brcmfmac43455-sdio.raspberrypi,4-model-b.txt
> Link: nvidia/gm206/acr/bl.bin -> ../../gm200/acr/bl.bin
> diederik@bagend:~/dev/kernel.org/linux-firmware$ grep -E "^File: .* .*" WHENCE
> File: "brcm/brcmfmac43241b4-sdio.Intel Corp.-VALLEYVIEW C0 PLATFORM.txt"
> File: "brcm/brcmfmac43340-sdio.ASUSTeK COMPUTER INC.-TF103CE.txt"
> File: "brcm/brcmfmac43430a0-sdio.ONDA-V80 PLUS.txt"
> File: "brcm/brcmfmac43455-sdio.MINIX-NEO Z83-4.txt"
> File: "brcm/brcmfmac4356-pcie.Intel Corporation-CHERRYVIEW D1 PLATFORM.txt"
> File: "brcm/brcmfmac4356-pcie.Xiaomi Inc-Mipad2.txt"
Ah, okie doke. Thanks for catching those.
> The last "Link: " line can be ignored due to being too crude ...
> but it does appear that it ONLY exists in the `brcm` directory ...
>
> > (that surprised me, but does seem to be the case. I'm writing to counteract
> > any sense that the proposed patch[2] could affect and fix many firmwares.
> > it won't, at least not today)
> >
> > [2] -
> > https://salsa.debian.org/kernel-team/firmware-nonfree/-/merge_requests/65
>
> https://lore.kernel.org/linux-firmware/20230301-fixes-and-compression-v2-0-e2b71974e842@gmail.com/
> seems related as f.e. 1 patch deals with the inconsistent " " vs "\ ".
>
> While I was inclined based on my findings above to mark it as an anomaly,
> that patch set seems to indicate that the spaces won't be removed in
> the future, just that its use would probably more consistent.
Ok, thanks again; perhaps it's worthwhile waiting a little longer for
upstream to decide on the preferred line format(s) they'll accept.
Reply to: