[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1030636: Debian Installer complains about missing firmware in ath10k, even when using image with firmware included



Hi Brandon,

Brandon Werner <brandon_code@fastmail.fm> (2023-02-06):
> Thanks for your response. I have included the syslog lines from the
> installer log you requested.

OK, that's basically what I thought was happening, but it's always a
good idea to check a hypothesis before deciding what to do about it. :)

I think I might have mentioned the following in some discussion, or
in some commit, but basically:
 - we have a list of requested files;
 - we have a list of requesting modules;
 - some modules get reloaded.

If we maintain a module/file mapping, we could:
 - decide which modules need to be reloaded, instead of iterating on all
   of them (that's part of the reason why I had this idea in mind in the
   first place, looking around how to “reload dance” was implemented:
   walking through all modules unconditionally);
 - decide that a module is “good to go” as soon as it's been reloaded
   once, i.e. some of the files it requested have been found.

The second part would make the point about “required” vs. “optional”
firmware moot, and would prevent extra dialogs. One could argue that
maybe some other *.deb somewhere could be more recent or could have
extra files, but then we don't implement anything when it comes to
multiplicity anyway, so that wouldn't be a regression.

Alternatively, we could keep the unconditionally reload dance, while
still keeping track of files requested by each module over time.
When the list gets smaller, its files start getting ignored.


Does that make sense to you?


Cheers,
-- 
Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

Attachment: signature.asc
Description: PGP signature


Reply to: