[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1029848: hw-detect: decide how to configure firmware support



Steve McIntyre <steve@einval.com> (2023-01-29):
> >I'm proposing:
> > - “hw-detect/firmware” as template for hw-detect;
> 
> I was thinking "hw-detect/load_firmware" might be better - we may
> want/need more firmware questions yet, so let's leave the namespace
> open?

That's exactly what someone has already thought about, and used to
implement the “Load missing firmware from removable media?” prompt.

If we really want not to use a bare /firmware, maybe /firmware-lookup?
But having something specialized in hw-detect and something much more
generic in preseed would look strange to me. I don't really mind either
way.

> > - “firmware” or “fw” as an alias for shorter typing (“fw” feels like
> >   extremely short);
> 
> I'd just go for "firmware" here; "fw" might be confused with firewall
> (I see Andy had a similar thought).

Agreed, let's go with “firmware”.

> > - “never” value to skip firmware handling altogether, meaning
> >   skipping both mechanisms mentioned above.
> 
> Maybe, yeah. That's probably clearest. Then we'd default to "always".

That's the *spirit* of it but not the letter:
 - I'm implementing support for “never”.
 - I'm not implementing support “always”. It doesn't exist. It isn't
   specified. This isn't the value you're looking for! :)

More seriously, the template doesn't even come with a default value. I'm
using db_get and "$RET" = never to implement early exit, that's all.

> >That would leave us a rather important flexibility regarding other
> >behaviours that we might want to implement, depending on the use
> >cases that might get identified (#1029543), without having to make a
> >decision about those (names and associated semantic) right now.
> 
> Yup, good call. We can extend this more to add the nuanced options
> once we've got the basics - let's do it incrementally!

Thanks for confirming the approach!


Cheers,
-- 
Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

Attachment: signature.asc
Description: PGP signature


Reply to: