[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1021918: debian-installer: Kernel module blacklisting inconsistent



On 08/11/2022 at 12:35, Olaf Meeuwissen wrote:

Pascal Hambourg <pascal@plouf.fr.eu.org> writes:

I could not reproduce this after tricking the installer into unloading
and reloading the mt7921e module. The module unloads and reloads
cleanly. But I do not have any hardware matching this module.

The freeze probably only occurs when an attempt to loadh the firmware
file is made.

I don't think so. I think it happens when unloading the module.

Anyway, this issue is not with this particular kernel module but with
the installer's inconsistent module blacklisting behaviour.

The freeze is related with this kernel module, not the installer.

It looks like a kernel bug when unloading this module. Can you trigger
the bug in an installed system ? If yes it means that it not specific
to the installer.

Checked this morning.  With the firmware file loaded, rmmod succeeds
without problems.  With the firmware file not loaded, trying to rmmod it
echoes "Killed" on the command-line and created a longish call trace in
/var/log/kern.log.  Not sure if it was the same, though.

As expected.

You may want to double check how the kernel command parse results
are used then.

I did, and <module>.blacklist works as expected with NIC modules
matching my hardware (iwlwifi and e1000e).

I meant double check by reading the source code

I did.

not by trying with some rather commonly used modules.

The blacklist handling is not related to a specific module, so any module matching present hardware will do.

You mentioned above that's a minor bug and easily fixed.  If so, then
please fix it.

I am not a Debian developer. The best I can do is submit a patch.

By all means, please do.  Thanks in advance.

Already done in another mail with attached patches sent to the bug.

The netinst one, according to the syslog I attached earlier.  Looking at
that log, I don't see any proof of the firmware loading error fly by
before the installer starts.

Indeed, the log clearly shows that the module is loaded at the "detecting networking hardware" step as expected.

I cannot reproduce the firmware file load failures before the installer
starts.
Consistent with the previous log.


Reply to: