[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#990065: unblock: squid-deb-proxy/0.8.15+nmu1



Control: tags -1 moreinfo d-i

On 2021-06-19 15:33:48 +0900, Hideki Yamane wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Please unblock package squid-deb-proxy
> 
> [ Reason ]
>  squid-deb-proxy needs its apparmor profile to work.
> 
> [ Impact ]
>  squid-deb-proxy does not work on bullseye
>  (There's a alternative, so not grave for all users).
> 
> [ Tests ]
>  Tested on KVM bullseye environment, it does not work well without
>  this changes as the bug report says, and patched system works fine.
> 
> [ Risks ]
>  None, IMHO.
>   - It's leaf package
>   - Its change does not affect its behavior, it's just for apparmor and
>     does not affect other package, too.
>   - Code is trivial one
> 
> [ Checklist ]
>   [x] all changes are documented in the d/changelog
>   [x] I reviewed all changes and I approve them
>   [x] attach debdiff against the package in testing
> 
> 
> unblock squid-deb-proxy/0.8.15+nmu1

> diff -Nru squid-deb-proxy-0.8.15/debian/apparmor-profiles/squid-deb-proxy squid-deb-proxy-0.8.15+nmu1/debian/apparmor-profiles/squid-deb-proxy
> --- squid-deb-proxy-0.8.15/debian/apparmor-profiles/squid-deb-proxy	1970-01-01 09:00:00.000000000 +0900
> +++ squid-deb-proxy-0.8.15+nmu1/debian/apparmor-profiles/squid-deb-proxy	2021-06-14 23:38:09.000000000 +0900
> @@ -0,0 +1,6 @@
> +# vim:syntax=apparmor
> +
> +    /etc/squid-deb-proxy/** r,
> +    /var/log/squid-deb-proxy/* rw,
> +    /run/squid-deb-proxy.pid rwk,
> +    /var/cache/squid-deb-proxy/** rw,
> diff -Nru squid-deb-proxy-0.8.15/debian/changelog squid-deb-proxy-0.8.15+nmu1/debian/changelog
> --- squid-deb-proxy-0.8.15/debian/changelog	2020-01-19 03:00:55.000000000 +0900
> +++ squid-deb-proxy-0.8.15+nmu1/debian/changelog	2021-06-14 23:41:11.000000000 +0900
> @@ -1,3 +1,10 @@
> +squid-deb-proxy (0.8.15+nmu1) unstable; urgency=medium
> +
> +  * Non-maintainer upload.
> +  * Add apparmor profiles to work (Closes: #932501)
> +
> + -- Hideki Yamane <henrich@debian.org>  Mon, 14 Jun 2021 23:41:11 +0900
> +
>  squid-deb-proxy (0.8.15) unstable; urgency=medium
>  
>    [ Graham Cantin ]
> diff -Nru squid-deb-proxy-0.8.15/debian/squid-deb-proxy.dirs squid-deb-proxy-0.8.15+nmu1/debian/squid-deb-proxy.dirs
> --- squid-deb-proxy-0.8.15/debian/squid-deb-proxy.dirs	2020-01-10 19:02:40.000000000 +0900
> +++ squid-deb-proxy-0.8.15+nmu1/debian/squid-deb-proxy.dirs	2021-06-14 23:40:40.000000000 +0900
> @@ -1,2 +1,3 @@
>  etc/resolvconf/update-libc.d
> +etc/apparmor.d/abstractions/squid-deb-proxy
>  var/log/squid-deb-proxy
> diff -Nru squid-deb-proxy-0.8.15/debian/squid-deb-proxy.install squid-deb-proxy-0.8.15+nmu1/debian/squid-deb-proxy.install
> --- squid-deb-proxy-0.8.15/debian/squid-deb-proxy.install	2020-01-10 19:02:40.000000000 +0900
> +++ squid-deb-proxy-0.8.15+nmu1/debian/squid-deb-proxy.install	2021-06-14 23:40:21.000000000 +0900
> @@ -1,3 +1,4 @@
>  ../update-libc.d etc/resolvconf/
>  etc/squid-deb-proxy
>  init-common.sh usr/share/squid-deb-proxy/
> +../apparmor-profiles/* etc/apparmor.d/abstractions/squid-deb-proxy/

I'm not an apparmor expert, but is this enough? Shouldn't there also be
a profile for the binary that uses this abstraction?

In any case, the package builds an udeb. Cyril, could you please (N)ACK
for D-I?

Cheers
-- 
Sebastian Ramacher

Attachment: signature.asc
Description: PGP signature


Reply to: