[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#999751: marked as done (di-netboot-assistant: please drop shellcheck autopkgtest)



Your message dated Thu, 18 Nov 2021 16:03:30 +0000
with message-id <E1mnjso-000GQO-5B@fasolo.debian.org>
and subject line Bug#999751: fixed in di-netboot-assistant 0.72
has caused the Debian Bug report #999751,
regarding di-netboot-assistant: please drop shellcheck autopkgtest
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
999751: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=999751
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Source: di-netboot-assistant
Version: 0.71
Severity: serious
X-Debbugs-CC: debian-ci@lists.debian.org, shellcheck@packages.debian.org
Tags: sid bookworm
User: debian-ci@lists.debian.org
Usertags: needs-update
Control: affects -1 src:shellcheck

Dear maintainer(s),

With a recent upload of shellcheck the autopkgtest of di-netboot-assistant
fails in testing when that autopkgtest is run with the binary packages
of shellcheck from unstable. It passes when run with only packages from
testing. In tabular form:

                       pass            fail
shellcheck             from testing    0.8.0-2
di-netboot-assistant        from testing    0.71
all others             from testing    from testing

I copied some of the output at the bottom of this report.

Currently this regression is blocking the migration of shellcheck to
testing [1]. Of course, shellcheck shouldn't just break your autopkgtest
(or even worse, your package), but in this case shellcheck just evolved.
Static analysis tools are intended to run on source code, while
autopkgtest is intended to run against installed packages, where source
code is in principle not relevant; we want to know whether the binary
packages, as provided in the Debian archive, work correctly. In our
opinion running this type of tools as integration tests in autopkgtest,
or even as build-time tests is Wrong™, and should not be done. (Having
them run in salsaci or equivalent is of course totally great.)

More information about this bug and the reason for filing it can be found on
https://wiki.debian.org/ContinuousIntegration/RegressionEmailInformation

[1] https://qa.debian.org/excuses.php?package=shellcheck

https://ci.debian.net/data/autopkgtest/testing/amd64/d/di-netboot-assistant/16684224/log.gz

autopkgtest [03:27:30]: test command1: shellcheck -x
/usr/bin/di-netboot-assistant ;       shellcheck -x -s dash
/var/lib/dpkg/info/di-netboot-assistant.post*
/var/lib/dpkg/info/di-netboot-assistant.pre*
autopkgtest [03:27:30]: test command1: [-----------------------

In /usr/bin/di-netboot-assistant line 452:
        echo -e "MENU BACKGROUND ::${s#$TFTP_ROOT}\n" >> pxelinux.cfg/default
                                       ^--------^ SC2295 (info):
Expansions inside ${..} need to be quoted separately, otherwise they
match as patterns.

Did you mean:
        echo -e "MENU BACKGROUND ::${s#"$TFTP_ROOT"}\n" >> pxelinux.cfg/default

For more information:
  https://www.shellcheck.net/wiki/SC2295 -- Expansions inside ${..} need to b...
autopkgtest [03:27:32]: test command1: -----------------------]
autopkgtest [03:27:32]: test command1:  - - - - - - - - - - results -
- - - - - - - - -
command1             FAIL non-zero exit status 1

I took the liberty to base the body of this email on bugreport
#992798, from Paul Gevers,

-- 
Samuel Henrique <samueloph>

--- End Message ---
--- Begin Message ---
Source: di-netboot-assistant
Source-Version: 0.72
Done: Andreas B. Mundt <andi@debian.org>

We believe that the bug you reported is fixed in the latest version of
di-netboot-assistant, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 999751@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas B. Mundt <andi@debian.org> (supplier of updated di-netboot-assistant package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 18 Nov 2021 16:27:29 +0100
Source: di-netboot-assistant
Architecture: source
Version: 0.72
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Andreas B. Mundt <andi@debian.org>
Closes: 999751
Changes:
 di-netboot-assistant (0.72) unstable; urgency=medium
 .
   * Add ARM64 and link EFI and grub files from the latest image installed.
   * Update sources, supported releases and architectures.
   * Update dependencies for autopkgtests.
   * Remove 'shellcheck' from autopkgtests (closes: #999751).
   * Remove conditional configuration for ancient package versions.
   * Update copyright information, minor fixes and improvements.
Checksums-Sha1:
 54bccb7ee7636669ec28cd3f43a83434916401db 1934 di-netboot-assistant_0.72.dsc
 86a6913e2c67199a61efa9170602f685aaff0c88 46212 di-netboot-assistant_0.72.tar.xz
 8ddd55477bb36f84a29897fb427080b0b1a9f32a 5653 di-netboot-assistant_0.72_amd64.buildinfo
Checksums-Sha256:
 e0c3d9296fa932401db353731f6d4521bc6257ecfcb38ce31cdff3011e928114 1934 di-netboot-assistant_0.72.dsc
 c3063de22343d89bb2024d4d28813fb0c240b05c99eb9dadbe4ea244cb65a0f8 46212 di-netboot-assistant_0.72.tar.xz
 bcc70ca425d002aad48305e5920ac92c1589180f9d5d4ade1159623805a8d42c 5653 di-netboot-assistant_0.72_amd64.buildinfo
Files:
 8395d0a9342e0acb3646614f43bb6ee8 1934 utils optional di-netboot-assistant_0.72.dsc
 8501d287c8c93bfae2863b36e46f279f 46212 utils optional di-netboot-assistant_0.72.tar.xz
 4a188d6831ae91a5c247a318847a7899 5653 utils optional di-netboot-assistant_0.72_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEk4pc7h4pDeJV2ayYsB/qhGF7WG0FAmGWdRgACgkQsB/qhGF7
WG2NFBAAiKkP0l3lFwvf/P0BFO3M8ihBG7jUQmp7QiFvzWTLmB/QnzstextJp/qx
Jo7+L+OFGmZe8xMfCTX8RoBC5a1RJf57PEaFwa1ikv6pxA2/EGjvVx/FVf2WUl2u
qt9210VEXB6RK7dfrPcdENROS/JaeYIY4FpyjLY/KQyMcEs966E7d1i0uH62XinJ
/bKzVju11cAUMN4+j46cguejN1EJWoJS9ANconbfx0NfCUFK/kahzc/G7ZWa1HWw
YRmsH82QBWjx5Mc1Jv1zSU8Z1pJZYyckgYOa5IAxLtz9LWFRhA+j4FYuevZ96hHH
WgYF/L4moa9q2NjhEtrGkJpC9dZ8ZwtLPeub/IYs3kavfD7cF4HEqnVNrcx2ze6r
VvldrADvnfgFgwtsX/tEvMuVA0EStRQppjKG5bpBkbZLsKTQAhRuhoW4XnyDd/HS
VCSxrKqwFGnGyLAzY5yJGcau8EQqxEVbhTckE0CkFQfDhy0BAjMMZXW39S0BoYb5
LhrfalxbI7tNgTHPnFlSS8Xh5sVKB9YIAjGcaj8pgGobeGUbtspQCII7hfWDiDBJ
9jLHFiRG4UN+NLIBMsM5aoG0soiRNqcrjgiVx4+0aBZmHUXnqnuRb86KyGtWXM/O
zdV5ulldvtQ11ADKCLDpe6MrbGLVyMKFZ6mpJECbvzbzgizlIR8=
=RlC1
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: