Your message dated Sat, 30 Oct 2021 18:30:54 +0200 with message-id <[🔎] 20211030183054.906cb9aac22395d0f32a6a86@mailbox.org> and subject line Mass-closing old grub-installer bugs has caused the Debian Bug report #780115, regarding grub-installer: fails on multi-device btrfs, zfs to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org immediately.) -- 780115: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=780115 Debian Bug Tracking System Contact owner@bugs.debian.org with problems
--- Begin Message ---
- To: submit@bugs.debian.org
- Subject: grub-installer: fails on multi-device btrfs, zfs
- From: Steven Chamberlain <steven@pyro.eu.org>
- Date: Mon, 9 Mar 2015 12:58:31 +0000
- Message-id: <20150309125830.GA21465@squeeze.pyro.eu.org>
- In-reply-to: <4498B2D3-5F4E-4003-96F6-FB72DFF90FC7@bayour.com>
- References: <4498B2D3-5F4E-4003-96F6-FB72DFF90FC7@bayour.com>
Package: grub-installer Version: 1.112 Severity: important User: debian-bsd@lists.debian.org Usertags: kfreebsd X-Debbugs-Cc: debian-bsd@lists.debian.org Hi, A section of code in grub-installer (dating back to lilo-installer) assumes that `grub-probe -t device` or 'findfs' returns only one device. Otherwise it fails with: Wrong number of args: mapdevfs <path> That's coming from here: http://anonscm.debian.org/cgit/d-i/grub-installer.git/tree/grub-installer?id=84d9a8936986f388feac192b785cc7ba98f9ce1d#n244 after rootfs, bootfs, bootfstype and rootfstype were all properly set. For a multi-disk mdraid or LVM, only one device path is returned, e.g. /dev/md0, /dev/mapper/foo-bar When modern filesystems btrfs and zfs are striped or mirrored across multiple devices, then findfs returns a list of devices, one per line. I'm not familiar if partman-btrfs allows to create multi-device sets. The kfreebsd installer allows to create such a configuration. This can happen using unofficial ZFS-on-Linux installer images too. That's the bug this patch refers to: https://lists.debian.org/debian-boot/2014/11/msg00181.html and fixed differently with this earlier proposal: http://anonscm.debian.org/cgit/d-i/grub-installer.git/commit/?h=zol&id=c96fd6c89445758fc6b5964d47c9d811bcb44238 It appears to have been reported and fixed in Ubuntu, differently again: https://bugs.launchpad.net/ubuntu/+source/grub-installer/+bug/1354730 https://code.launchpad.net/~tj/ubuntu/trusty/grub-installer/lp1354730/+merge/230222 All three fixes look a bit of a hack to me, but picking any one device works as a placeholder until this code reaches a conclusion that is inevitable. The purpose of this code is to find indications it should fall back to grub-legacy. In the case of btrfs, zfs, and some other situations it is mandatory to use grub2 anyway: http://anonscm.debian.org/cgit/d-i/grub-installer.git/tree/grub-installer?id=84d9a8936986f388feac192b785cc7ba98f9ce1d#n374 I think if bootfstype was tested earlier, a lot of this legacy code could be skipped over or 'optimised out'. Awkwardly though, variables stay in scope until the end of this long script, and it's hard to see if something gets (re-)used later. findfs gets used in some more places and I'm not sure yet if it's satisfactory in *all* places to to consider only the first one. Regards, -- Steven Chamberlain steven@pyro.eu.org
--- End Message ---
--- Begin Message ---
- To: debian-boot <debian-boot@lists.debian.org>
- Cc: 785149-done@bugs.debian.org, 489005-done@bugs.debian.org, 610116-done@bugs.debian.org, 611713-done@bugs.debian.org, 612420-done@bugs.debian.org, 621923-done@bugs.debian.org, 647267-done@bugs.debian.org, 659116-done@bugs.debian.org, 665856-done@bugs.debian.org, 666552-done@bugs.debian.org, 668923-done@bugs.debian.org, 686955-done@bugs.debian.org, 690515-done@bugs.debian.org, 690592-done@bugs.debian.org, 702731-done@bugs.debian.org, 729411-done@bugs.debian.org, 771467-done@bugs.debian.org, 780115-done@bugs.debian.org, 806164-done@bugs.debian.org, 806849-done@bugs.debian.org, 416986-done@bugs.debian.org, 292513-done@bugs.debian.org, 310798-done@bugs.debian.org, 391489-done@bugs.debian.org, 489006-done@bugs.debian.org, 578338-done@bugs.debian.org, 582367-done@bugs.debian.org, 229128-done@bugs.debian.org, 463842-done@bugs.debian.org, 497168-done@bugs.debian.org, 500079-done@bugs.debian.org, 516392-done@bugs.debian.org, 520361-done@bugs.debian.org, 544949-done@bugs.debian.org, 549703-done@bugs.debian.org, 557242-done@bugs.debian.org, 580461-done@bugs.debian.org, 587699-done@bugs.debian.org, 588670-done@bugs.debian.org, 596877-done@bugs.debian.org, 612025-done@bugs.debian.org, 618498-done@bugs.debian.org, 639713-done@bugs.debian.org, 666559-done@bugs.debian.org, 699456-done@bugs.debian.org, 703901-done@bugs.debian.org, 707604-done@bugs.debian.org, 711330-done@bugs.debian.org, 609939-done@bugs.debian.org, 498831-done@bugs.debian.org
- Subject: Mass-closing old grub-installer bugs
- From: Holger Wansing <hwansing@mailbox.org>
- Date: Sat, 30 Oct 2021 18:30:54 +0200
- Message-id: <[🔎] 20211030183054.906cb9aac22395d0f32a6a86@mailbox.org>
Hi, similar to the installation-reports bugs, I'm closing the grub-installer reports below. These are reports for Debian 4 / 6 / 7 / 9 where grub-installer fails (for various reasons). There have been numerous changes/improvements on this topics in the past, and also because of the age of the reports we should consider these problems as being fixed (or it is even reported in the bugs that they are fixed). They are most likely of no use anymore for recent releases. If you know, that the issue you reported (and gets closed here) is still existing in recent installation images, please file a new report for that with up-to-date details! Thank you for filing these bug reports, they have been very useful at the time they were filed! https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=785149 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=489005 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=610116 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=611713 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=612420 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=621923 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=647267 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=659116 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=665856 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=666552 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=668923 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=686955 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=690515 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=690592 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=702731 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=729411 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=771467 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=780115 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=806164 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=806849 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=416986 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=252009 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=292513 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=310798 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=391489 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=489006 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=578338 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=582367 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=229128 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=463842 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=497168 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=500079 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=516392 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=520361 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=544949 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=549703 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=557242 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=580461 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=587699 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=588670 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=596877 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=612025 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=618498 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=639713 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=666559 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=699456 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=703901 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=707604 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=711330 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=609939 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=498831 Cheers Holger -- Holger Wansing <hwansing@mailbox.org> PGP-Fingerprint: 496A C6E8 1442 4B34 8508 3529 59F1 87CA 156E B076
--- End Message ---