--- Begin Message ---
Package: grub-installer
Version: 1.175
Severity: important
X-Debbugs-Cc: Steve McIntyre <93sam@debian.org>
Hi,
Calling this important since it gives a wrong indication to users trying
to rescue their systems. During smoke testing for #987377, once the hang
is fixed, I've toyed with other options like reinstalling the bootloader.
I was surprised to find out that the rescue mode interface reports there
was an error while grepping -i for GRUB in /var/log/syslog only returned
the usual success messages from grub-install, yet we get an error code
set to 1…
A wild guess (unconfirmed at this stage, it's a little late in the day)
is a regression coming from this commit:
https://salsa.debian.org/installer-team/grub-installer/-/commit/5eada0008eede06c97d55adca1a9eb1eb9447aee
Namely, rescue.d/80grub-reinstall gets this new code (excerpt):
chroot /target mount /boot/efi || true
EXTRA_PATHS="$EXTRA_PATHS /target/boot/efi"
trap "umount $EXTRA_PATHS" HUP INT QUIT KILL PIPE TERM EXIT
The first line does generate an error/warning message that's harmless
(seen in /var/log/syslog, not in the interface) for BIOS systems.
But the suspected culprit is the unconditional addition of
/target/boot/efi (that's unlikely to exist on such systems) to
EXTRA_PATHS, coupled with the trap call. Since the umount there isn't
guarded with a “|| true”, and since the trap is deployed for EXIT as
well, it might be that we're trying to exit successfully, but end up
triggering an error due to the ENOENT when unmounting.
If that's confirmed, it might be better to guard this differently, e.g.
via:
if [ -e /target/boot/efi ]; then
chroot /target mount /boot/efi || true
EXTRA_PATHS="$EXTRA_PATHS /target/boot/efi"
fi
so that we can still throw errors when unmounting other items of the
EXTRA_PATHS list, without purposefully generating an error that we would
ignored via “|| true”, also ignoring possible other errors in the
process…
That's just a vague gut feeling, feel free to adjust in the best way
you can imagine. :)
Cheers,
--
Cyril Brulebois (kibi@debian.org) <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant
--- End Message ---
--- Begin Message ---
Source: grub-installer
Source-Version: 1.178
Done: Steve McIntyre <93sam@debian.org>
We believe that the bug you reported is fixed in the latest version of
grub-installer, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 988826@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Steve McIntyre <93sam@debian.org> (supplier of updated grub-installer package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Tue, 15 May 2021 01:20:31 +0100
Source: grub-installer
Architecture: source
Version: 1.178
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Steve McIntyre <93sam@debian.org>
Closes: 988826
Changes:
grub-installer (1.178) unstable; urgency=medium
.
[ John Paul Adrian Glaubitz ]
* Add support for Apple PowerMacintosh (New World)
.
[ James Addison ]
* Add conditional tests around mount cleanup logic. Closes: #988826
Checksums-Sha1:
16ffaa223bf3a3840eb995b89674085a13323ce3 2050 grub-installer_1.178.dsc
1fd2eee6820e469783093c1b09af3d0673bef25d 229084 grub-installer_1.178.tar.xz
23f7620d0ee62e7e007559e14be0407c06a9bd7f 6098 grub-installer_1.178_source.buildinfo
Checksums-Sha256:
6a9292eb56a5e3b297638f672dcd58f81cdb581037c6a018404655266691a0a9 2050 grub-installer_1.178.dsc
093e20f2bd5d44bb4070664ec2262f70a21b2487705b3d5554768e1cfe31deb0 229084 grub-installer_1.178.tar.xz
433150d3e2591131657a934c67925c1dbe8fdbfdbe96a1f6e5959bed0613d83f 6098 grub-installer_1.178_source.buildinfo
Files:
c77e6f746f9ff52036f45a8a8627419e 2050 debian-installer standard grub-installer_1.178.dsc
7462035e7d37569fbf10f729ef43e18e 229084 debian-installer standard grub-installer_1.178.tar.xz
b7cff8e8682b071ec9350ca02fd52c9b 6098 debian-installer standard grub-installer_1.178_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJFBAEBCAAvFiEEzrtSMB1hfpEDkP4WWHl5VzRCaE4FAmCsSBARHDkzc2FtQGRl
Ymlhbi5vcmcACgkQWHl5VzRCaE4PIQ/8CSrgV+X7f7Ve1FgAF1RahMRqv73Kp47L
nAqAZ25ci8l7EvzKy2bI8GEtP4zjy85niu1tXv6un36X4sOfATggOeDE2ptRU+Dm
UFTOGJyEXhkMibCvu7zZIqqSseLeDq0herE+FGLdf9XsP2dK0FCpUybxTyQW0CoM
qwJF5bYZiWgqjIkmQmKnsB5/7QCiCHVTQMY0ybG4tDD4WOEaIj9lG9PCwhEsyecy
e3pdpb3E4sk1X35xgEFOv59E1iSyHniiYjXF0RRKRT70X8KegWgSRe8k1qeUN1UV
S2GX/o7KLNT3/AUacRHYVm2RMC4VYjZXN/Kh3uB1E9n8wOyly2EyX85deLoqBJ5Y
QSsHYmSDoTIyaGFCu19hlsDzEspXoO2SPoytlHFtjL1d1QD7J5UWdsPsvEWpYUiv
fZ7jZNsx/20szbPg0OP70U7lydUvEILO+eL65S7RANV26ujJZEKCmmH5rp0yAQVP
57eGvV5LD6pLCUCKsOg9lRXcx5tyf2aHeyuYR+hHyl1T7HMVbRPs1ZsK6a5vgZ2S
mbEol+hxRqheN+OB+blVWvrdNFzU5RxCWderKEtNiooDTxCZqG+I6QDAlTCKjB5+
y0Kkmt9NArtJTOqMDUyyIWuJhvpJN71pda0jASlN04LOutJ7bCkeqlkE0e7aueNm
crtWMwFLcbM=
=FDVG
-----END PGP SIGNATURE-----
--- End Message ---