[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#401693: marked as done (Patch to make the g-i fulscreen)

Your message dated Sat, 22 May 2021 07:07:20 +0200
with message-id <YKiRiL95bwYUUp/R@mraw.org>
and subject line Re: Bug#401693: Patch to make the g-i fulscreen
has caused the Debian Bug report #401693,
regarding Patch to make the g-i fulscreen
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org

401693: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=401693
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
package: cdebconf-gtk-udeb
severity: wishlist
tags: patch

GTK frontend has currently a fixed size 800x600, but on some machines (especially PPCs) the framebuffer device has a fixed size which is greater than 800x600, resulting in a ugly frame around the installer.
This patch takes care of making the frontend going "fullscreen".

--- gtk.c	2006-12-05 12:56:44.000000000 +0100
+++ gtk.c.fullscreen	2006-12-05 13:02:00.000000000 +0100
@@ -57,9 +57,6 @@
 #include <directfb.h>
-#define WINDOW_WIDTH 800
-#define WINDOW_HEIGHT 600
 /* maximum length for string questions */
 #define STRING_MAX_LENGTH 128
@@ -67,6 +64,7 @@
+int screen_width, screen_height;
 typedef int (gtk_handler)(struct frontend *obj, struct question *q, GtkWidget *questionbox);
 static GCond *button_cond = NULL;
@@ -245,7 +243,7 @@
             pango_layout_set_font_description(layout, pango_font_description_from_string("Sans 12"));
             pango_layout_get_pixel_size(layout, &w, &h);
             /* obj->info is drawn over the debian banner, top-right corner of the screen */
-            gdk_draw_layout(wid->window, gdk_gc_new(wid->window),  WINDOW_WIDTH - w - 4, 4, layout);
+            gdk_draw_layout(wid->window, gdk_gc_new(wid->window),  screen_width - w - 4, 4, layout);
@@ -1445,8 +1443,10 @@
     gtk_init (&args, &name);
+    screen_width = gdk_screen_get_width (gdk_screen_get_default ());
+    screen_height = gdk_screen_get_height (gdk_screen_get_default ());
     window = gtk_window_new (GTK_WINDOW_TOPLEVEL);
-    gtk_widget_set_size_request (window, WINDOW_WIDTH, WINDOW_HEIGHT);
+    gtk_widget_set_size_request (window, screen_width, screen_height);
     gtk_window_set_resizable (GTK_WINDOW (window), TRUE);
     gtk_window_set_position (GTK_WINDOW (window), GTK_WIN_POS_CENTER);
     gtk_window_set_decorated (GTK_WINDOW (window), TRUE);

--- End Message ---
--- Begin Message ---
Version: 0.123

Attilio Fiandrotti <attilio.fiandrotti@gmail.com> (2006-12-06):
> Given it's more a feature implementation than a bugfix, i'll postpose to
> Etch release, pherhaps adding capability to load a user-specified image for
> custom debian builders benefit.

This happened in r49705:

    commit 345db88a74b3ac47c9e581f994d5ee98e6bc333a
    Author: Jérémy Bobbio <lunar@debian.org>
    Date:   Thu Oct 4 15:58:35 2007 +0000
        Merge changes to the GTK+ frontend from the "fe_gtk" branch.
         - Rewritten codebase, more readable and documented.
         - Switch "Screenshot" button as secondary.
         - Define a clear API for plugins.

Closing, finally. :)

Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

Attachment: signature.asc
Description: PGP signature

--- End Message ---

Reply to: