[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#981666: cdrom-detect: Preseeding cdrom-detect/load_media and a high-enough priority lead to failure



Package: cdrom-detect
Version: 1.92
Severity: normal
X-Debbugs-Cc: j2468h@gmail.com

Dear Maintainer,

Recently experimenting with a rather obscure setup that involves running the installer from a non-cdrom device and preseeding, I've discovered that cdrom-detect doesn't allow cdrom-detect/load_media to be preseeded.
This is caused by debconf returning code 30 if the question isn't shown, this error code should be ignored to allow preseeding, the attached patch fixes the issue.
It has been tested by hand editing the postinst script on a live system, as I don't know how to rebuild the debian installer initrd.

- Jonathan Hettwer (bauen1)

-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.10.0-2-amd64 (SMP w/4 CPU threads)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: SELinux: enabled - Mode: Enforcing - Policy name: bauen1-policy
>From b4a968def3fe7cc16bdbc68427634ca457efcfd0 Mon Sep 17 00:00:00 2001
From: bauen1 <j2468h@gmail.com>
Date: Tue, 2 Feb 2021 18:11:01 +0100
Subject: [PATCH] allow preseeding cdrom-detect/load_media

---
 debian/cdrom-detect.postinst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/cdrom-detect.postinst b/debian/cdrom-detect.postinst
index 6bf2454..4b99d66 100755
--- a/debian/cdrom-detect.postinst
+++ b/debian/cdrom-detect.postinst
@@ -153,7 +153,7 @@ while true; do
  
 	# If no device was detected, perhaps a driver floppy is needed.
 	if [ -e /usr/lib/debian-installer/retriever/media-retriever ]; then
-		db_input critical cdrom-detect/load_media
+		db_input critical cdrom-detect/load_media || [ $? -eq 30 ]
 		db_go
 		db_get cdrom-detect/load_media
 		if [ "$RET" = true ]; then
-- 
2.30.0


Reply to: