[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#972076: tasksel suggests the use of mktemp instead of tempfile



Control: severity -1 minor
Control: tags -1 patch

Am 12.10.2020 um 10:45 schrieb Markus Steinko:

> Package: tasksel
> Version: 3.59
> Severity: normal
>
> Dear Maintainer,
>
> *** Reporter, please consider answering these questions, where
>     appropriate ***
>
>    * What led up to the situation?
>
>         Using tasksel to install some task, or with the --new-install
> option
>         ends successfully, but with a warning:
>         WARNING: tempfile is deprecated; consider using mktemp instead.

The warning comes from tempfile itself, added in debianutils 4.10.  The
obvious, but untested attached patch fixes that, although it might be
better to use File::Temp instead (in perl-base since version 5.20.1-3).

Cheers,
       Sven

From 198ec980d51c45e9fb8ea818c4380e15ddb039ad Mon Sep 17 00:00:00 2001
From: Sven Joachim <svenjoac@gmx.de>
Date: Mon, 12 Oct 2020 19:11:43 +0200
Subject: [PATCH] Avoid tempfile deprecation warning

Since debianutils 4.10, tempfile is deprecated in favor of mktemp.
---
 tasksel.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tasksel.pl b/tasksel.pl
index 356798fb..0adb6800 100755
--- a/tasksel.pl
+++ b/tasksel.pl
@@ -710,7 +710,7 @@ sub interactive {
 			$question="tasksel/first";
 		}
 		my @default = grep { $_->{_display} == 1 && ($_->{_install} == 1 || $_->{_installed} == 1) } @tasks;
-		my $tmpfile=`tempfile`;
+		my $tmpfile=`mktemp`;
 		chomp $tmpfile;
 		my $ret=system($debconf_helper, $tmpfile,
 			task_to_debconf_C(@list),
--
2.28.0


Reply to: