[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#959668: os-prober: translated auto-added items in other installs are not recognized as such



Hi Benno,

Benno Schulenberg <bensberg@telfort.nl> (2020-05-03):
> When the hard disk contains multiple partitions, each with a Debian-based
> distro (in my case: Xubuntu, Elementary, MX Linux, and Linux Mint) and each
> of these distros is localized, then updating each system in turn results in
> the grub.cfg file of each system getting larger and larger with each upgrade.
> 
> The cause is that the 40grub2 script does not recognize the automatically
> added menu references to the other distros because the relevant grep command
> checks for the word "on".  And in translations, this word will be different.

My first hunch would be, given languages are tricky: “Don't assume
anything! Can it be that depending on the language, the device might
get mentioned first, and other words get postfixed instead?”

> -				elif echo "$title" | grep -q '(on /dev/[^)]*)$'; then
> +				elif echo "$title" | grep -q '(\w\+ /dev/[^)]\+)$'; then

In which case maybe matching '(.*/dev/[^)]\+.*)' would make the fix a
little more general? (Don't trust that pattern too much, -ENOCOFFEE…)


And indeed, looking at grub2's po/*.po (e.g. in buster), checking the
translations (msgstr) for that message (msgid), excluding those wih %s
at the end, and those without any translations, we can see:

    (buster-amd64-devel)kibi@armor:/tmp/grub2-2.02+dfsg1$ grep -A1 '^msgid "(on %s)"' po/*.po | grep po-msgstr | grep -v '%s)"' | grep -v 'po-msgstr ""'
    po/ja.po-msgstr "<b>依存プラグイン:</b>"
    po/pa.po-msgstr "(%s ਉੱਤੇ)"
    po/tr.po-msgstr "(%s üzerinde)"


→ Punjabi, and Turkish wouldn't be fixed.
→ Japanese is apparently suffering from fuzzy translations, which
  explains why the format doesn't even look similar.


Cheers,
-- 
Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

Attachment: signature.asc
Description: PGP signature


Reply to: