Bug#950587: rootskel: kernel argument parsing in S02module-params ignores quoting

[Ferenc Wágner <wferi@debian.org>]

Package: rootskel
Severity: normal

Dear Maintainer,

If I preseed multiple nameservers on the kernel command line, like for
example netcfg/get_nameservers="193.225.12.63 193.225.14.58", in the
installed system the following /etc/modprobe.d/local.conf appears:

----------8<----------
# Local module settings
# Created by the Debian installer

options 193.225.14 225.14.58"=193.225.14.58"
----------8<----------

Indeed, if I pass a="b c.d" on the kernel command line, the
misunderstanding is already present in the installer environment:

----------8<----------
~ # cat /var/lib/register-module/c.params
options:d"=c.d"
----------8<----------

The problematic code is S02module-params in rootskel. Proper and secure
quote handling is indeed pretty hard in shell programming, but security
isn't relevant in the Debian Installer context, so using shell eval
seems acceptable and probably provides the easiest solution.

Please consider fixing this some way.
-- 
Thanks,
Feri.