Martin Samuelsson <debianbts2020@nurysto.netizen.se> writes: ... > Reading README.wget404[1] clearly states this output redirection dance is > never actually used, and that this convoluted expression merely exists > because it could possibly-maybe be useful some day. As far as I can see the > callers of wget404() does indeed not use its output. > > Given that this construct does cause real world problems, without adding any > actual value, how would you consider having wget404() simplified to simply > consume the error message and thus skip all usage of &3 and &4? Seems fair enough to me -- if the wget output is actually needed at some point in the future, one can always get hold of the sed incantation from git. That being the case, a warning could be added to the modified wget404 to say that it now discards output, and that if that's a problem one should look at <relevant commit> for a version that manages to preserve it, as long as /dev/fd/4 is available. The fact that /dev/fd/4 is missing does seem to be a separate bug, but a quick grep -lr suggests that this is the only place it's used in d-i, so perhaps a bug we need not worry about too much. Cheers, Phil. -- |)| Philip Hands [+44 (0)20 8530 9560] HANDS.COM Ltd. |-| http://www.hands.com/ http://ftp.uk.debian.org/ |(| Hugo-Klemm-Strasse 34, 21075 Hamburg, GERMANY
Attachment:
signature.asc
Description: PGP signature