[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#962925: partman-efi: improve non_efi_system question



Package: partman-efi
Version: 84
Severity: minor

If find the partman-efi/non_efi_system question somewhat confusing.

If one sets it to 'false' that means the installer will configure
the system for BIOS mode booting, even if the installer is running
in EFI mode.
If one sets it 'true', then even if there are partitions that look
like they require non-EFI booting, the system will be set up to
boot in EFI mode.
The default is not indicated in the template but seems to be 'false'.

I feel this could be improved by either inverting the logic of the
setting or changing the question name.

If we think how 'non_efi_system: false' reads (to a nonspecialist)
it suggests we have an EFI(-only) system, does it not?
But in fact it is intended to mean the opposite case.

A better question name might be: partman-efi/efi_boot_only.
This would work with the existing logic settings and I think
conveys the intent of the question more clearly.
I'm not sure how name changes like this are effected in d-i,
presumably one adds the new one and starts a deprecation of
the old one?

Kind regards
Vince

tiny patch to show what the default setting is:

diff --git a/debian/partman-efi.templates b/debian/partman-efi.templates
index af3f8e4..cf766da 100644
--- a/debian/partman-efi.templates
+++ b/debian/partman-efi.templates
@@ -44,6 +44,7 @@ _Description: EFI partition too small
 
 Template: partman-efi/non_efi_system
 Type: boolean
+Default: false
 # :sl2:
 _Description: Force UEFI installation?
  This machine's firmware has started the installer in UEFI mode but

Reply to: