Hi Adrian, thank you for your suggestions, I implemented them (and rebased the branch on the current master). On 02.06.20 17:48, John Paul Adrian Glaubitz wrote: > Hi Igor! > > On 6/2/20 5:32 PM, Igor Scheller wrote: >> Did I did something wrong with it? >> Is it really so poorly written that no one is even considering having a >> look at it? >> Is no body interested in fixing that (esp. as i'v heard from some people >> that they also need that feature)? > Two remarks: > > - Your change is missing a changelog entry in debian/change (generated > with "dch --no-auto-nmu"). that's definitely a point that i missed, sorry for that > - The two commits should be squashed into one commit titled: > > "Add support for preseeded pointopoint mode" I squashed the commits as they definitely are not useful > Btw, I'm surprised the keyword is actually called "pointopoint" and > not "pointtopoint", but the manpage of ifconfig actually calls > it like that. > > Adrian Greets Igor
Attachment:
signature.asc
Description: OpenPGP digital signature