--- Begin Message ---
- To: Debian Bug Tracking System <submit@bugs.debian.org>
- Subject: live-installer does not remove live packages in the installed system
- From: "Rui Miguel P. Bernardo" <rui.bernardo.pt@gmail.com>
- Date: Mon, 09 Jan 2012 07:45:24 +0000
- Message-id: <20120109074524.29177.98077.reportbug@debian64.home>
Package: live-installer
Version: 34
Severity: normal
Tags: d-i patch
Dear Maintainer,
I've noticed that debian-installer-launcher was not removed in the
installed system, as were not removed also live-config, live-boot and
others.
The problem was that a missing var initialization of do_manual_removal
in finish-install.d/60remove-live-packages, preventing the packages to
be manually removed by default.
do_manual_removal=true
Related to this is the search for /cdrom/live/filesystem.packages-remove
file. I suppose the /cdrom is not mounted when
finish-install.d/60remove-live-packages is executed, so the file
/cdrom/live/filesystem.packages-remove is not found, and I can confirm
that the file *is* in the image.
/usr/lib/finish-install.d # ls
01kickseed
05crypto
05localechooser
06user-setup
07brltty
07preseed
07speakup
10apt-cdrom-setup
10clock-setup
15cdrom-detect
20final-message
30hw-detect
50config-target-network
55netcfg-network-manager
60cleanup
60remove-live-packages
65partman-md
90base-installer
90console
94save-logs
95umount
97release-dhcp-lease
98exit-installer
99reboot
/usr/lib/finish-install.d # grep /cdrom *
10apt-cdrom-setup:if [ -e /cdrom/.disk/base_installable ] && \
10apt-cdrom-setup: [ -e /cdrom/.disk/cd_type ] && \
10apt-cdrom-setup: [ "$(cat /cdrom/.disk/cd_type)" = not_complete ] && \
10apt-cdrom-setup: sed -i "/^deb cdrom:/s/^/#/" /target/etc/apt/sources.list
15cdrom-detect: logger -t cdrom-detect "$@"
15cdrom-detect:# Cannot just tell eject to eject /cdrom as it is not compatible
15cdrom-detect:# with busybox umount. Instead, unmount the cdrom first, and then
15cdrom-detect:CDDEV=$(mount | grep "on /cdrom" | cut -d ' ' -f 1)
15cdrom-detect: umount /cdrom || true
15cdrom-detect: db_get cdrom-detect/eject
60remove-live-packages:for list in /cdrom/live/filesystem.packages-remove; do
I could not find any mount or umount command in
/usr/lib/finish-install.d/*, just in 15cdrom-detect. Maybe it's
15cdrom-detect that umounts the /cdrom. If it is "cdrom-detect" is
misleading.
If that's the case then something should be done. Move
60remove-live-packages to before 15cdrom-detect (or vice-versa), or just
remove "manually" the live packages, or something else.
Anyway, to fix/workaroung the original problem by removing manually the
packages, adding the variable an initial value makes the "manual"
removal happen.
Patch attached. Thank you.
>From 20ba218a7b3507a5cba54b78e6453b387aa4dc3a Mon Sep 17 00:00:00 2001
From: "Rui Miguel P. Bernardo" <rui.bernardo.pt@gmail.com>
Date: Mon, 9 Jan 2012 06:07:25 +0000
Subject: [PATCH] Initialize do_manual_removal var.
---
finish-install.d/60remove-live-packages | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/finish-install.d/60remove-live-packages b/finish-install.d/60remove-live-packages
index aab6db2..a70466e 100755
--- a/finish-install.d/60remove-live-packages
+++ b/finish-install.d/60remove-live-packages
@@ -1,5 +1,7 @@
#!/bin/sh -e
+do_manual_removal=true
+
# Remove packages as specified in specific package removal list
for list in /cdrom/live/filesystem.packages-remove; do
if [ -e $list ]; then
--
1.7.7.1
-- System Information:
Debian Release: wheezy/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 3.0.0-1-amd64 (SMP w/1 CPU core)
Locale: LANG=pt_PT.UTF-8, LC_CTYPE=pt_PT.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
>From 20ba218a7b3507a5cba54b78e6453b387aa4dc3a Mon Sep 17 00:00:00 2001
From: "Rui Miguel P. Bernardo" <rui.bernardo.pt@gmail.com>
Date: Mon, 9 Jan 2012 06:07:25 +0000
Subject: [PATCH] Initialize do_manual_removal var.
---
finish-install.d/60remove-live-packages | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/finish-install.d/60remove-live-packages b/finish-install.d/60remove-live-packages
index aab6db2..a70466e 100755
--- a/finish-install.d/60remove-live-packages
+++ b/finish-install.d/60remove-live-packages
@@ -1,5 +1,7 @@
#!/bin/sh -e
+do_manual_removal=true
+
# Remove packages as specified in specific package removal list
for list in /cdrom/live/filesystem.packages-remove; do
if [ -e $list ]; then
--
1.7.7.1
--- End Message ---