Hi, Guilhem Moulin <guilhem@debian.org> (2019-07-27): > Control: severity -1 grave > > Hi, > > On Thu, 25 Jul 2019 at 22:31:36 +0100, Ben Hutchings wrote: > >> Thanks to the Recommends: d-i will automatically pull the initramfs > >> integration, at least on systems where APT::Install-Recommends hasn't > >> been turned off by preseeding. (The Recommends: cryptsetup-run is there > >> to improve the upgrade path, cf. #932625.) I'm therefore only raising > >> the severity to ‘normal’. > > > > APT::Install-Recommends is only enabled after the base-installer phase. > > of installation. I don't know what stage cryptsetup is installed at, > > but I suggest it's worth checking that this assumption is correct. > > Thanks for the hint, ‘cryptsetup-initramfs’ is not pulled in indeed. I > guess someone would have found out sooner or better, but the sooner the > better :-) > > The attached patch fixes this. I'll leave it to you if you want to > clone this bug and close -1, or alternatively downgrade its severity to > conditionally implement the initramfs integration: At this point (releasing an Alpha 1 for Bullseye), I've merged your patch, and I'll be double checking this fixes the encrypted LVM use case once it's hit the archive. Thanks! > | The real fix would be to have a detection logic triggering `apt-install > | cryptsetup` whenever there are crypt targets in the dm table, and > | `apt-install cryptsetup-initramfs` if any volume needs to be unlocked at > | initramfs stage, i.e., holding /, /usr, and/or the resume device(s). Cheers, -- Cyril Brulebois (kibi@debian.org) <https://debamax.com/> D-I release manager -- Release team member -- Freelance Consultant
Attachment:
signature.asc
Description: PGP signature