On Fri, 2019-11-01 at 00:09 +0100, Holger Wansing wrote:
> Hi,
>
> Ben Hutchings <ben@decadent.org.uk> wrote:
> > On Sun, 2019-10-27 at 20:18 +0100, Holger Wansing wrote:
> > > Bugreport against kernel version mismatch, when using outdated or broken
> > > netboot images:
> > >
> > >
> > > Since it's unlikely that we completely prevent this issue to happen, maybe we
> > > could at least change the error message, saying that the user should try
> > > another / a newer installation image?
> > > (as already suggested in bug#367515)
> > >
> > > It would be a good time for such template changing now...
> > > Patch attached.
> >
> > I feel that we ought to give a more definite answer, instead of "you
> > can try" and "will probably fail". I don't think that "choosing to
> > install a different version of Debian" is likely to be a useful answer
> > very often, and continuing without kernel modules is definitely going
> > to fail.
> >
> > If I understood correctly, this message can only appear when using a
> > netboot image, and can be caused by either (a) old netboot image or (b)
> > broken mirror. If that's right, we should recommend (a) make sure your
> > netboot image is current (b) if it is, then try another mirror,
> > recommending deb.debian.org.
>
> That looks reasonable.
> I have prepared a proposal for this:
The new text looks good to me.
[...]
> > Also, this should be an error message, not a question.
>
> For this, I would need some help, since I'm lacking the needed skills there.
> The relevant part of anna.c seems to be:
[....]
> if (!kernel_packages_present) {
> di_log(DI_LOG_LEVEL_WARNING, "no packages matching running kernel %s in archive", running_kernel);
> #ifdef __GNU__
> /* GNU Mach does not have modules */
> #else
> debconf_input(debconf, "critical", "anna/no_kernel_modules");
> if (debconf_go(debconf) == 30)
> return 0;
> debconf_get(debconf, "anna/no_kernel_modules");
> if (strcmp(debconf->value, "false") == 0)
> return 0;
I think that for an error message the above 5 lines (after
debconf_input(...)) can be changed to:
debconf_go(debconf);
return 0;
[...]
> I assume, just turning
>
> ===== snip ====
> Template: anna/no_kernel_modules
> Type: boolean
> Default: false
> # :sl2:
> _Description: Continue the install without loading kernel modules?
> ===== snap ====
>
> into
>
> ===== snip ====
> Template: anna/no_kernel_modules
> Type: error
> # :sl2:
> _Description: No kernel modules found
> ===== snap ====
>
> is not enough here?
Right, because there will no longer be any answer for the code to get.
Ben.
--
Ben Hutchings
Reality is just a crutch for people who can't handle science fiction.
Attachment:
signature.asc
Description: This is a digitally signed message part