Bug#925979: busybox-udeb: breaks user-params, rescue mode, etc.
Package: busybox-udeb
Version: 1:1.30.1-1
Severity: serious
Justification: breaks d-i features
(Maintainers cc'd explicitly.)
Hi,
With the upgrade to the 1.30.x series, a bunch of patches were reworked,
and some were dropped. This includes:
debian/patches/temp-deb-installer-hack.patch
Upstream indeed has a change that looks like it should be obsoleting our
local hack:
https://salsa.debian.org/installer-team/busybox/commit/9c143ce52da11ec3d21a3491c3749841d3dc10f0
But in practice, that means that rescue/enable=true is no longer visible
from the rescue-check binary package (from src:rescue), meaning a broken
rescue mode. I expect a number of other features to be broken in the
same way, via the user-params script in debian-installer-utils.
(In hindsight, this could be related to some other strange things I've
seen lately with some installation scenarios which include preseeding
settings on the kernel command line…)
Restoring the patch is not sufficient, as the context obviously changed.
Given there were few changes there, I've tried reverting the upstream
commit (9c143ce52da11ec3d21a3491c3749841d3dc10f0), restoring
temp-deb-installer-hack.patch and enabling the relevant config option
(only for the udeb build). debian-installer rebuilt against such a
patched busybox-udeb seems to be working fine again.
Besides the fact we should probably switch away from the current way we
do things (see thread from November 2017 starting at:
https://lists.debian.org/debian-boot/2017/11/msg00205.html — but that
won't happen now), I suppose it would be good to let upstream know the
above commit doesn't actually help us much?
I've just pushed my (dirty and incremental) kibi/user-params-workaround
branch to the repository:
https://salsa.debian.org/installer-team/busybox/commits/kibi/user-params-workaround
I'd be happy to have a fix for this before we consider releasing D-I
Buster RC 1, which could otherwise be ready next week. If maintainers
could hint me into the right direction, that could be sufficient. ;)
Thanks for your time.
Cheers,
--
Cyril Brulebois (kibi@debian.org) <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant
Reply to: