Re: [PATCH] Adding definition of Raspberry Pi Family
Hi,
Disclaimer: I'm neither part of Debian's boot nor kernel team.
Here is some feedback:
On Tue, Feb 05, 2019 at 01:55:27PM +0100, Alexandre GRIVEAUX wrote:
> Adding definition according to:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts?h=v4.20
> https://packages.debian.org/stretch/armhf/linux-image-4.9.0-8-armmp/filelist
> https://packages.debian.org/stretch/arm64/linux-image-4.9.0-8-arm64/filelist
>
> A merge request was opened 1 month ago but without reply on:
>
> https://salsa.debian.org/installer-team/flash-kernel
> ---
> db/all.db | 63 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 63 insertions(+)
>
> diff --git a/db/all.db b/db/all.db
> index 6197d08..4b01b31 100644
> --- a/db/all.db
> +++ b/db/all.db
> @@ -1474,6 +1474,62 @@ Boot-Script-Path: /boot/boot.scr
> U-Boot-Script-Name: bootscr.uboot-generic
> Required-Packages: u-boot-tools
>
> +Machine: Raspberry Pi 1 Model A
> +Kernel-Flavors: armmp armmp-lpae
> +DTB-Id: bcm2835-rpi-a.dtb
> +U-Boot-Script-Name: bootscr.uboot-generic
> +Required-Packages: u-boot-tools
> +Boot-Script-Path: /boot/boot.scr
armmp is only build for armhf, which means ARMv7 in Debian. RPi 1 is
ARMv6, so this is not a safe operation in Debian. Note, that
Raspbian uses a different definition of armhf.
> +Machine: Raspberry Pi 1 Model A+
> +Kernel-Flavors: armmp armmp-lpae
> +DTB-Id: bcm2835-rpi-a-plus.dtb
> +U-Boot-Script-Name: bootscr.uboot-generic
> +Required-Packages: u-boot-tools
> +Boot-Script-Path: /boot/boot.scr
The above is obviously true for all RPi 1 entries.
> +Machine: Raspberry Pi 1 Model B
> +Kernel-Flavors: armmp armmp-lpae
> +DTB-Id: bcm2836-rpi-2-b.dtb
This is RPi 2 DT, but your description claims RPi 1.
RPi 2 is already supported, so this can be dropped?
> +U-Boot-Script-Name: bootscr.uboot-generic
> +Required-Packages: u-boot-tools
> +Boot-Script-Path: /boot/boot.scr
> +
> +Machine: Raspberry Pi 1 Model B+
> +Kernel-Flavors: armmp armmp-lpae
> +DTB-Id: bcm2835-rpi-b-plus.dtb
> +U-Boot-Script-Name: bootscr.uboot-generic
> +Required-Packages: u-boot-tools
> +Boot-Script-Path: /boot/boot.scr
> +
> +Machine: Raspberry Pi 1 Model B Rev2
> +Kernel-Flavors: armmp armmp-lpae
> +DTB-Id: bcm2835-rpi-b-rev2.dtb
> +U-Boot-Script-Name: bootscr.uboot-generic
> +Required-Packages: u-boot-tools
> +Boot-Script-Path: /boot/boot.scr
> +
> +Machine: Raspberry Pi 1 Compute Module
> +Kernel-Flavors: armmp armmp-lpae
> +DTB-Id: bcm2835-rpi-cm1-io1.dtb
> +U-Boot-Script-Name: bootscr.uboot-generic
> +Required-Packages: u-boot-tools
> +Boot-Script-Path: /boot/boot.scr
> +
> +Machine: Raspberry Pi Zero
> +Kernel-Flavors: armmp armmp-lpae
> +DTB-Id: bcm2835-rpi-zero.dtb
> +U-Boot-Script-Name: bootscr.uboot-generic
> +Required-Packages: u-boot-tools
> +Boot-Script-Path: /boot/boot.scr
> +
> +Machine: Raspberry Pi Zero W
> +Kernel-Flavors: armmp armmp-lpae
> +DTB-Id: bcm2835-rpi-zero-w.dtb
> +U-Boot-Script-Name: bootscr.uboot-generic
> +Required-Packages: u-boot-tools
> +Boot-Script-Path: /boot/boot.scr
> +
> Machine: Raspberry Pi 2 Model B
> Kernel-Flavors: armmp armmp-lpae
> DTB-Id: bcm2836-rpi-2-b.dtb
> @@ -1495,6 +1551,13 @@ U-Boot-Script-Name: bootscr.uboot-generic
> Required-Packages: u-boot-tools
> Boot-Script-Path: /boot/boot.scr
>
> +Machine: Raspberry Pi 3 Compute Module
> +Kernel-Flavors: arm64 armmp armmp-lpae
> +DTB-Id: bcm2835-rpi-cm3-io3.dtb
> +U-Boot-Script-Name: bootscr.uboot-generic
> +Required-Packages: u-boot-tools
> +Boot-Script-Path: /boot/boot.scr
This seems to be a sensible addition, but the DT file for this
module is actually bcm2837-rpi-cm3-io3.dtb. I suppose you did
not test your changes?
> +
> Machine: Rockchip RK3288 Tinker Board
> Kernel-Flavors: armmp armmp-lpae
> DTB-Id: rk3288-tinker.dtb
-- Sebastian
Reply to: