[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#919023: marked as done (Simplification of BOOTCFG_CreateGUID function)

Your message dated Wed, 16 Jan 2019 20:54:11 +0000
with message-id <E1gjsCR-000FmU-8g@fasolo.debian.org>
and subject line Bug#919023: fixed in win32-loader 0.9.4
has caused the Debian Bug report #919023,
regarding Simplification of BOOTCFG_CreateGUID function
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
919023: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=919023
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: win32-loader
Version: 0.9.3
Severity: normal
Tags: patch
The conversion of an UUID value into a string can be achieved by just using the g (GUID) type of the System plug-in. As a consequence the Win32 API calls could be eliminated. 

-- System Information:
Debian Release: 9.6
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.18.0-0.bpo.3-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8) 
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

win32-loader depends on no packages.

win32-loader recommends no packages.

Versions of packages win32-loader suggests:
pn  wine  <none>

>From e735da16c5059c680d279a00de8cdf3c0e1bf53e Mon Sep 17 00:00:00 2001
From: Thomas Gaugler <thomas@dadie.net>
Date: Fri, 11 Jan 2019 22:04:52 +0100
Subject: [PATCH] Simplification of BOOTCFG_CreateGUID function

The conversion of an UUID value into a string can be achieved by just using the g (GUID) type of the System plug-in. As a consequence the Win32 API calls could be eliminated.
---
 include/bootcfg.nsh | 16 +---------------
 1 file changed, 1 insertion(+), 15 deletions(-)

diff --git a/include/bootcfg.nsh b/include/bootcfg.nsh
index 59ca3f4..3b087e4 100644
--- a/include/bootcfg.nsh
+++ b/include/bootcfg.nsh
@@ -1868,7 +1868,6 @@ FunctionEnd
   Push $0
   Push $1
   Push $2
-  Push $3
 
   ; Initialize return value
   StrCpy $0 ""
@@ -1876,24 +1875,11 @@ FunctionEnd
   ${If} $2 != 0
     System::Call "rpcrt4::UuidCreate(p r2) i.r1"
     ${If} $1 == 0
-      ; Create reference pointer
-      System::Call "*(&t0) p.r3"
-      ${If} $3 != 0
-        System::Call "rpcrt4::UuidToString(p r2, pr3r3) i.r1"
-        ${If} $1 == 0
-          ; Extract string from reference pointer
-          System::Call "*$3(p .r0)"
-          System::Call "*$0(&t${NSIS_MAX_STRLEN} .r0)"
-          StrCpy $0 "{$0}"
-          System::Call "rpcrt4::RpcStringFree(pr3)"
-        ${EndIf}
-        System::Free $3
-      ${EndIf}
+      System::Call "*$2(g .r0)"
     ${EndIf}
     System::Free $2
   ${EndIf}
 
-  Pop $3
   Pop $2
   Pop $1
   Exch $0
-- 
2.20.1

--- End Message ---
--- Begin Message --- 
Source: win32-loader
Source-Version: 0.9.4

We believe that the bug you reported is fixed in the latest version of
win32-loader, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 919023@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Didier Raboud <odyx@debian.org> (supplier of updated win32-loader package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 16 Jan 2019 21:12:07 +0100
Source: win32-loader
Binary: win32-loader
Architecture: source
Version: 0.9.4
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Didier Raboud <odyx@debian.org>
Description:
 win32-loader - Debian-Installer loader for win32
Closes: 919023
Changes:
 win32-loader (0.9.4) unstable; urgency=medium
 .
   [ Thomas Gaugler ]
   * Simplification of BOOTCFG_CreateGUID function (Closes: #919023)
Checksums-Sha1:
 4227f4199191613ba50656bd1a096f51796d7783 1809 win32-loader_0.9.4.dsc
 69d11ae02adeb626ce2acbd2a080020198ebd29e 233412 win32-loader_0.9.4.tar.xz
Checksums-Sha256:
 2c43bca253aaa4fec8c7de1fd1d114ed009178b9bc1c3ebd4615d499f0e0ca9d 1809 win32-loader_0.9.4.dsc
 1a3d2a41619b30497aa8c8bbe429c6be22c5000f0c39466f3416f3a0f25fb068 233412 win32-loader_0.9.4.tar.xz
Files:
 d69ce84c8ee3101b1d8d380c9e8fd507 1809 utils optional win32-loader_0.9.4.dsc
 231567093dcd72184262bb168dcb93a3 233412 utils optional win32-loader_0.9.4.tar.xz

-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEEe+WPIRpjNw1/GSB7i8+nHsoWNFUFAlw/kisACgkQi8+nHsoW
NFXwSQv8Dn2J0snuiGy9rSjBmPQpl7T0pMd2y1hdQBwhf7o1iNEj09Z5hzl9N1k8
+Nn7Ag+P9alrlx108Ks7SnCBa+PtIaw2D4NPlv3KKdRJPg/6NbCLdOCe65Tc3hLN
iLUT2U/M4fgM3shsG7mpBwfrxRwvxDm4l3AeRHxgFWZyHewDrfdubiQedV5P85GY
bcIvQNUtX1WkguMS0ya3H0Zed3zLtf7No1yGvsx+SpDR/2szhhKanjnKSShQgF0c
wwPkJs5dH6kGCh4P+rS8zuJsfeReGCIr38SUoJ4RvFHWQ2ky2Q+7WJa/NVBcfeR7
KkjeY8gI22d4f4wqA+iaMphvfmXaxDN/jrig1qXV2M7fZp2Lowkoe1wkVykljEbt
SE5rQ2HxBCxnVu3Y4YY/393mhoNEjV56XrNNhNDZQbHQdJ1+uWWwu4ej8YA4nGBF
RjAHzFSGnV9h75G9/DrvuDeL/3sK9JpL4aSMsYBav0FXhPVx4ej72yCJ3MQpOIIj
D+ZPgWpo
=qxfL
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: