[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#906696: flash-kernel: Please add an entry for the Rock64



On 2018-08-27, Josua Mayer wrote:
> Am 24.08.2018 um 14:55 schrieb Héctor Orón Martínez:
>> Missatge de Josua Mayer <josua.mayer97@gmail.com> del dia dg., 19
>> d’ag. 2018 a les 22:00:

>>> Only one important thing has to be dealt with: Getting the DTB loaded by U-Boot!
>>> U-Boot searches for rockchip/rk3328-rock64.dtb in /, /dtb/, /dtb/current on the EFI partition.
>>>
>>> The attached db entry takes care ot this particular path by storing it at /boot/efi/dtb/rockchip/rk3328-rock64.dtb.
>> This is with vendor u-boot instead Debian u-boot, right?
> Right.
> More precsisely:
> U-Boot (upstream) has efi_dtb_prefixes=/ /dtb/ /dtb/current/.
> It searches for $fdtfile in those places before loading and efi application.
>
> This is shared by the vendor u-boot.
> The only trouble is that fdtfile is set to "rockchip/rk3328-rock64.dtb"
> rather than plain "rk3328-rock64.dtb" like other rockchip boards
> supported in upstream do.
> ^^
> I think this is the pain point.

Other arm64 rockchip boards also use the vendor prefix in recent
versions, at least in current u-boot git master (see:
a2a5053a15e4059c7445737d60f7b8425ca863f8). Only 32-bit arm boards do not
include the vendor prefix, just like in the linux kernel.

If any of the tooling doesn't support with a vendor prefix, it should be
fixed.


> I have been watching the u-boot mailinglist and there was nothing.
> There only seems to be this single person Kamil Trzciński doing serious
> work in this direction.
> E.g. see his mainline branch on github:
> https://github.com/ayufan-rock64/linux-u-boot/commits/mainline-master
> It looks like he might want to push these up stream at one point.

Indeed, I've been keeping an eye on it and occasionally nudging to push
upstream. I even tried patching the Debian u-boot packaging from those
branches, but haven't managed to get a working booted system yet.

Once it lands upstream, especially with some testing from others, I can
happily add it to u-boot in Debian.


> It was his decision to go with the rockchip subfolder:
> https://github.com/ayufan-rock64/linux-u-boot/commit/9c204e7343577e8b922556bf9349a457c139976e

> I guess we could ask him to accept a patch allowing the dtb to reside at
> the root level? That way it would behave like upstream rockchip boards.

I don't really agree that it's consistant with other rockchip boards
(see above).

All arm64 linux dtbs are in sub-dirs, flash-kernel supports them in
sub-dirs, and u-boot should generally just append the value of fdtfile
to whatever search path and look for it there.


>>> Currently most used and best documented source for rock64 U-Boot:
>>> https://github.com/ayufan-rock64/linux-u-boot/releases
>>>
>>> u-boot-erase-spi-rock64.img.xz can be used to flash u-boot to SPI flash once;
>>> from then on everything is standard:
>>> - debootstrap
>>> - linux-image-arm64
>>> - grub-arm-efi
>>> - grub-install --target=arm-efi --removable

Thanks for the pointers.


live well,
  vagrant

Attachment: signature.asc
Description: PGP signature


Reply to: