[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#903122: debian-installer-9-netboot-amd64: Please add char/virtio_console module (paravirtualized serial) to netinst



On Tue, 2018-07-10 at 02:32 +0200, Cyril Brulebois wrote:
> Control: reassign -1 src:linux
> Control: tag -1 patch
> 
> Ben Hutchings <ben@decadent.org.uk> (2018-07-09):
> > I would say virtio-modules.  All the virtio class drivers depend on
> > virtio and virtio_ring, which means that adding them to any other
> > package would require that package to depend on virtio-modules.
> > 
> > (The Xen-specific drivers don't have this issue only because xenbus
> > unfortunately has to be built-in.)
> 
> Alright, I've implemented this in the attached patches, one for sid, and
> one for stretch. I didn't run any test builds, but I've verified that
> contrary to some other virtio* modules, virtio_console is built
> everywhere (CONFIG_VIRTIO_CONSOLE=m in debian/config/config), so should
> be added without '?'.

For the kernel-wedge config, it generally doesn't matter whether a
driver might be built-in.  The "copy-modules" sub-command checks in the
"modules.builtin" file before looking for a real module file.  It's
only a problem if all the modules listed for a package are built-in,
because an empty package is treated as an error (maybe that should just
be a warning?).

Ben.

> Thanks for considering.

-- 
Ben Hutchings
If you seem to know what you are doing, you'll be given more to do.

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: