[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#902350: systemd-container: /proc/1/environ doesn't contain


Hideki Yamane <henrich@iijmio-mail.jp> (2018-06-25):
> On Mon, 25 Jun 2018 21:43:41 +0900 Hideki Yamane <henrich@iijmio-mail.jp> wrote:
> >  I've got a suggestion to use $container to detect systemd-nspawn,
> >  it can be used before/after 239-1. debootstrap should be changed
> >  to use it, so reassign to debootstrap.

Without looking at the actual changes in systemd etc., just a quick
glance at the proposed changes:

>  I've created MergeRequest as
>  https://salsa.debian.org/installer-team/debootstrap/merge_requests/13

Please anchor the grep pattern to avoid accidental matches against
variables whose name ends with container (e.g. foo_container), and
values which start with lxc-libvirt (e.g. lxc-libvirt-something-else);
adding ^ on the left and $ on the right would do that.

It seems there are quite a number of other places with such issues.

Also, please use grep -qs instead of redirecting channels to /dev/null?

Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

Attachment: signature.asc
Description: PGP signature

Reply to: