[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#893300: cdebconf: Adding support for a pkg.cdebconf.nogtk build-profile

On Mon, Mar 26, 2018 at 12:50:26PM +0200, Karsten Merker wrote:
> On Mon, Mar 26, 2018 at 12:47:18AM +0100, Colin Watson wrote:
> > I think this would be clearer reversed, i.e.:
> > 
> >   DEB_FRONTENDS=passthrough text newt
> >   UDEB_FRONTENDS=passthrough text newt
> > 
> >   ifeq ($(filter pkg.cdebconf.nogtk,$(DEB_BUILD_PROFILES)),)
> >       DEB_FRONTENDS+=gtk
> >       UDEB_FRONTENDS+=gtk
> >   endif
> That's probably a matter of taste :-).  I found it clearer to
> have the primary DEB_FRONTENDS and UDEB_FRONTENDS assignments to
> always represent the default case when no build-profiles are
> enabled and only modify them in the "non-standard" case of having
> a build-profile set.  If you have a strong preference for the
> "additive" version instead of the "subtractive" version, please
> let me know and I'll change that.

It's not a strong preference; feel free to disregard my comment if you
have a strong preference the other way.

Colin Watson                                       [cjwatson@debian.org]

Reply to: