[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#798562: debootstrap: Support "scripts" sharing code with Debian but with different default_mirror and keyring



Hi,

On Sat, 24 Feb 2018, Hideki Yamane wrote:
> On Thu, 10 Sep 2015 16:22:25 +0200 =?utf-8?q?Rapha=C3=ABl_Hertzog?= <hertzog@debian.org> wrote:
> > It might be possible to just move the code out in some separate
> > files that can be sourced from all the "script" files?
> 
>  I've made a PoC patch for this issue
>  - relocate scripts files to each distro directroy

I think this is not a good idea. The location of the scripts file is part
of the public interface since debootstrap takes a script file
as 4th parameter.

Or maybe it's a good idea because we are going to have collisions one day
between codenames of the various distributions but then you have to keep
the current files for a little longer and you probably should consider
further changes so that we can pass "debian/sid" or "kali/kali-rolling"
as 1st parameter (suite).

But this is also not required to implement this:

>  - split code from scripts/debian/sid

This part looks fine from a cursory review.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/


Reply to: