[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#884376: marked as done (flash-kernel: ubootenv.d snippets silently ignored)

Your message dated Mon, 08 Jan 2018 09:04:03 +0000
with message-id <E1eYTLf-0000jY-HB@fasolo.debian.org>
and subject line Bug#884376: fixed in flash-kernel 3.90
has caused the Debian Bug report #884376,
regarding flash-kernel: ubootenv.d snippets silently ignored
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
884376: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=884376
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: flash-kernel
Version: 3.88
Severity: normal
Tags: patch

Dear Maintainer,

Since most bootscr.* template still misses the @@UBOOT_ENV_EXTRA@@
marker please consider applying the attached patch to warn the
user about their snippet being ignored.

Hopefully the message has enough details that the user can fix
up the template without having to read flash-kernel code like
I had to do to figure it out.

Regards,
Andreas Henriksson

>From b86a051ee0a0c748d30eb455f39b5005ae6c29aa Mon Sep 17 00:00:00 2001
From: Andreas Henriksson <andreas@fatal.se>
Date: Thu, 14 Dec 2017 17:34:04 +0100
Subject: [PATCH] Warn when ubootenv.d snippet will be ignored

Previously if you dropped in an bootscript snippet in
/etc/flash-kernel/ubootenv.d/ and the bootscr.* template
did not contain @@UBOOT_ENV_EXTRA@@ (which most don't)
the snippet would be silently ignored.

Warn the user and give some hints on where to look for the
solution in the warning message.
---
 functions | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/functions b/functions
index b2ae5be..6a2cde9 100644
--- a/functions
+++ b/functions
@@ -461,6 +461,11 @@ mkimage_script() {
 	local ubootenv="$(mktemp --tmpdir=$tmpdir)"
 	gen_ubootenv > $ubootenv
 
+	if [ "$(stat --printf='%s' $ubootenv)" -gt 0 ] && \
+           ! grep -q '@@UBOOT_ENV_EXTRA@@' "$sdata" ; then
+		echo "WARNING: ubootenv.d snippet used, but $sdata has no @@UBOOT_ENV_EXTRA@@ marker. Snippet will be ignored." >&2
+        fi
+
 	printf "Generating boot script u-boot image... " >&2
 	sed -e "s/@@KERNEL_VERSION@@/$kvers/g" \
             -e "s!@@LINUX_KERNEL_CMDLINE@@!$(get_kernel_cmdline)!g" \
-- 
2.15.1

--- End Message ---
--- Begin Message --- 
Source: flash-kernel
Source-Version: 3.90

We believe that the bug you reported is fixed in the latest version of
flash-kernel, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 884376@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christian Perrier <bubulle@debian.org> (supplier of updated flash-kernel package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 08 Jan 2018 06:54:35 +0100
Source: flash-kernel
Binary: flash-kernel flash-kernel-installer
Architecture: source
Version: 3.90
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Christian Perrier <bubulle@debian.org>
Description:
 flash-kernel - utility to make certain embedded devices bootable
 flash-kernel-installer - Make the system bootable (udeb)
Closes: 870430 883547 884375 884376
Changes:
 flash-kernel (3.90) unstable; urgency=medium
 .
   [ Andreas Henriksson ]
   * Make ubootenv.d work on Wandboard (Closes: #884375).
   * Warn when ubootenv.d snippet will be ignored (Closes: #884376).
 .
   [ Vagrant Cascadian ]
   * Add option to allow "any" in Kernel-Flavors (Closes: #883547).
 .
   [ Ian Campbell ]
   * Fix local shadow of $dtb_name in handle_dtb (Closes: #870430).
   * Reduce scope of $dtb in handle_dtb.
 .
   [ Christian Perrier ]
   * Remove Loic, Hector and Ian from Uploaders. Thanks for your work
   * Add Vagrant and Karsten in Uploaders.
Checksums-Sha1:
 033059f5437ce6375da90b96effc22b114af379c 1854 flash-kernel_3.90.dsc
 ca555e0565c684d7f1ac71eb9a93f9be60d0d120 70080 flash-kernel_3.90.tar.xz
Checksums-Sha256:
 02f6e195abd1c65247e6c92b9b0682482314fe353cfb2a48c03c2f1baed0e026 1854 flash-kernel_3.90.dsc
 e3b2e9b89aace8183ee5d77edf70c47df4a411522d46400f40fd4f6da4ae0f35 70080 flash-kernel_3.90.tar.xz
Files:
 ddb830e10513c1c57d563bf8eb337dda 1854 utils optional flash-kernel_3.90.dsc
 76c601987d6e48ee11f33768c4121e08 70080 utils optional flash-kernel_3.90.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE1cL5v8oSi7oip3IYhy9wLE1uJagFAlpTMvAACgkQhy9wLE1u
JagGKg//Y+CkV7kaVnUUmk8FBa4nFQuNFLJVyjAftume+5HzaM4yrQulcSBzBPTV
eHbqnkgNvX+6fIw4wl+HZc444ZYMxo6TA+8v0WTsbGXhFhSq2BHXjmotrAECj6ZB
iP7A1l0PtzLfndjHpPNVespYyg0pX7yCodfijqtexzhH7Jo3mFelFx4VDC2ATFMy
IJZ5hr3bot6cjQf/coVRnF6e5xIitrB+whmW/cOfWiAwNjoQBAyTrqs3ongUCEVU
eG+NT9wiXQ8l/NXlc+hzft4dDuSCSpEq3YiI7oTjzpfNL2obO1TcYNwcM1WT53g1
NIDvQG6jRaJ9RHuQgzVU1X4SS6jSLu8A6zLwK5NVUMCwyCqNiWHsksaPsL6QpBVd
o9HXJhl27FPT2TtNKifT9UWdMqQC+iYRS5zU8YIYFlPXqJjN5hizOr2XkSSCChu+
6Qcjx63cnAVsLqc9ZyguzpS1IMkBmF5WdhyojNcr4NIAc2tcjaE65C/cb9cG2k/Z
jUD6oBRr/HR4uB905RkgHEWrbi+S5aDiEFl/Ar0FJ3ss+tMmBXF7UJcPIGjuc3/Y
vlRIdZnJ65cEhFLhPhtphmArwTNG3DSOkrkwUgoBiY127XKRrxWyxSHiV2d3F+z0
jpkpgA5ddSQZ0CVyJCiXJkmDEqAbcI2nh3Y70XmcyV0SMeIDIGk=
=IqON
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: