[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#855489: marked as done (lilo-installer: fails in postinst: sfdisk: invalid option -- '1')



Your message dated Sun, 19 Feb 2017 06:33:25 +0000
with message-id <E1cfL3l-000G88-Tf@fasolo.debian.org>
and subject line Bug#855489: fixed in lilo-installer 1.52
has caused the Debian Bug report #855489,
regarding lilo-installer: fails in postinst: sfdisk: invalid option -- '1'
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
855489: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=855489
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: lilo-installer
Version: 1.51
Severity: grave
Justification: renders package unusable


(reported by "jim" on #debian-boot)

After choosing LILO rather than GRUB as the boot loader, lilo-installer fails
when invoking sfdisk.

Tested on /dev/vda and /dev/vda1.


A totally untested idea for a patch attached.
>From 227e1812e381be61b40330e372d62348a9e8dd75 Mon Sep 17 00:00:00 2001
From: Adam Borowski <kilobyte@angband.pl>
Date: Sun, 19 Feb 2017 05:43:39 +0100
Subject: [PATCH] Reverse the order of arguments to sfdisk -A, add a space.

During a massive overhaul in util-linux 2.26, sfdisk -A accidentally changed
meaning to --append.  This change was later reverted, but while doing so the
parsing and argument order have changed.
---
 debian/postinst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian/postinst b/debian/postinst
index 58ab0ce..f81f89b 100755
--- a/debian/postinst
+++ b/debian/postinst
@@ -155,7 +155,7 @@ if (echo "${bootdev}" | grep -v '/c[0-9]d[0-9]$' | grep -q '[0-9]$') \
 		if [ "${RET}" = "true" ]; then
 			pnum=$(echo ${bootdev} | sed 's/^.*\([0-9]\+\)$/\1/')
 			echo -n "I: Setting partition to active..." >&2
-			sfdisk -A${pnum} ${disc_offered_devfs}
+			sfdisk --activate ${disc_offered_devfs} ${pnum}
 			echo "done." >&2
 		fi
 	fi
@@ -174,7 +174,7 @@ if [ "${raid_boot}" = no ] && (! fdisk -l "$disc_offered_devfs" | grep '^/dev/'
 		# /boot.
 		pnum="$(echo "$bootfs" | sed 's/^.*\([0-9]\+\)$/\1/')"
 		echo -n "I: Setting partition $bootfs to active..." >&2
-		sfdisk -A"$pnum" "$disc_offered_devfs"
+		sfdisk --activate ${disc_offered_devfs} ${pnum}
 		echo "done." >&2
 	fi
 fi
-- 
2.11.0


--- End Message ---
--- Begin Message ---
Source: lilo-installer
Source-Version: 1.52

We believe that the bug you reported is fixed in the latest version of
lilo-installer, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 855489@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Cyril Brulebois <kibi@debian.org> (supplier of updated lilo-installer package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 19 Feb 2017 06:59:34 +0100
Source: lilo-installer
Binary: lilo-installer
Architecture: source
Version: 1.52
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Cyril Brulebois <kibi@debian.org>
Description:
 lilo-installer - Install LILO on a hard disk (udeb)
Closes: 855489
Changes:
 lilo-installer (1.52) unstable; urgency=medium
 .
   [ Adam Borowski ]
   * Reverse the order of arguments to sfdisk -A, and switch to --activate
     for extra safety since util-linux upstream had -a/-A mixed up at some
     point, and support for old syntax was dropped anyway (Closes: #855489).
Checksums-Sha1:
 e9b81ad7c3a0750c08e50a8e933697ce458a834e 1676 lilo-installer_1.52.dsc
 649cc15f0b1c7d05cab37bd6eab260fc23f6d773 101108 lilo-installer_1.52.tar.xz
Checksums-Sha256:
 f503c55039a75ad6639b77b5b69ddd2cb15c9273c816c996b9047d876d50ac02 1676 lilo-installer_1.52.dsc
 94f4d5c6a27420ac7d3811131b2835ca97afaba746e8d5789f0de205e7028e80 101108 lilo-installer_1.52.tar.xz
Files:
 2a3f2e3a80a2db7bc4fc7031266bd7a0 1676 debian-installer standard lilo-installer_1.52.dsc
 b57e7de3c1430eafe5f4a8efd5111219 101108 debian-installer standard lilo-installer_1.52.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJYqThcAAoJEP+RSvDCs1UgqU4P/jcM+7Rv6oPhqecuml0hCbq/
sOqj6aq4eZJa6EImYIQirf2oa+cDTPZRHyOwkyy2ixN7rMWJMdVT4hewoQUdbPz5
55CZrAYJ56lsSqJsfwxe2agmjuVZQo2TR+idp4qHPnbV6eyYWgY84UYOeX+nsx4C
qIluIOkSyJWDS/JIaXMSE1pE7MJ2CVctPosJ7j8bc5j1DfF7GeK8Iev+OX1mt+nO
X+mno5XryMRSJjV1CQDXZ2jhrffyb34Ycl/H5uTAB+UONJJaCWJcsMXy8sTiJyhd
LMMVl02hW7lz5oBjHap2G+SPjvkKpOsyEWRO/Zz/D2rdJ8+wKD/SOmChh3dfPKBZ
FQO3qTN23ZwM2wPVIsAEtzKO/2jsoGLzf8oW3wOuONNMeIQvwUJySQRYAj6l46ym
ZnuJPiSFGHLBWWXMlB2Acepvt8yuaCRWoVTvdxvENDCq41XYEcuZLjqvNIkOPK8G
M1OaGmSrzuh54xKIqizpO1VxixFAclW7MqJ6kauM7XMIAvRS6QJAh+2xxQgNI3L0
kBJW2VxSLJgN5zaLSBSOVsdhN2XojjE5CElNI3JglfFV3jYS/+XGS2PNj3UYDVH1
LLki54pe+PjOJ8TDuYmtGOivNlq3qkj+XLtTP1xg9tziHNq2eec7oEDPusrKeaw1
cLkm5iBEaq90yeEtM64I
=5uw8
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: