[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#868859: marked as done (iso-scan: should also scan LVM logical volumes)

Your message dated Mon, 11 Dec 2017 07:04:50 +0000
with message-id <E1eOI8w-0008r0-NS@fasolo.debian.org>
and subject line Bug#868859: fixed in iso-scan 1.61
has caused the Debian Bug report #868859,
regarding iso-scan: should also scan LVM logical volumes
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
868859: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=868859
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: iso-scan
Version: 1.57
Severity: normal
Tags: patch
User: devel@kali.org
Usertags: origin-kali kali-patch
Control: block -1 by 868848 868852

With this patch, I ensure that we activate LVM logical volumes so that
they are visible by "list-devices" and so that they can be scanned too.

That way we are also able to identify ISO images stored within LVM
logical volumes.
    
Obviously this has implications on the rest of the installation process.
The logical volume will be in use and the partitioning step will have
to preserve the logical volume and its parent volume group.
    
But partman is perfectly able to cope with the logical volumes being
already activated so it should be fine to do this here.
    
For this patch to work, we need some changes in:
- debian-installer-utils: https://bugs.debian.org/868848
- debian-installer hd-media image: https://bugs.debian.org/868852

Please find my suggested (and tested) patch attached.

-- System Information:
Debian Release: buster/sid
  APT prefers oldoldstable
  APT policy: (500, 'oldoldstable'), (500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/

>From d4914795492c2a4b85bbe1e3a8a7de7f9aa571a1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Hertzog?= <hertzog@debian.org>
Date: Tue, 18 Jul 2017 16:59:32 +0200
Subject: [PATCH] Detect and scan LVM logical volumes too

That way we are also able to identify ISO images stored within LVM
logical volumes.

Obviously this has implications on the rest of the installation process.
The logical volume will be in use and the partitioning step will have
to preserve the logical volume and its parent volume group.

But partman is perfectly able to cope with the logical volumes being
already activated so it should be fine to do this here.

For this patch to work, we need some changes in:
- debian-installer-utils: https://bugs.debian.org/868848
- debian-installer hd-media image: https://bugs.debian.org/868852
---
 debian/changelog         | 7 +++++++
 debian/iso-scan.postinst | 6 ++++++
 2 files changed, 13 insertions(+)

diff --git a/debian/changelog b/debian/changelog
index 4345d57..6abd1db 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+iso-scan (1.58) UNRELEASED; urgency=medium
+
+  * Detect LVM logical volumes so that they can be used to find the ISO image
+    that we are looking for.
+
+ -- Raphaël Hertzog <hertzog@debian.org>  Tue, 18 Jul 2017 16:58:13 +0200
+
 iso-scan (1.57) unstable; urgency=medium
 
   [ Updated translations ]
diff --git a/debian/iso-scan.postinst b/debian/iso-scan.postinst
index a21ed85..e34f329 100755
--- a/debian/iso-scan.postinst
+++ b/debian/iso-scan.postinst
@@ -271,6 +271,12 @@ while :; do
 		done
 		modprobe loop >/dev/null || true
 
+		# Detect LVM logical volumes if possible
+		modprobe dm_mod >/dev/null || true
+		if type vgchange >/dev/null; then
+			vgchange -a y >/dev/null || true
+		fi
+
 		mkdir /cdrom 2>/dev/null || true
 		mkdir /hd-media 2>/dev/null || true
 
-- 
2.13.3

--- End Message ---
--- Begin Message --- 
Source: iso-scan
Source-Version: 1.61

We believe that the bug you reported is fixed in the latest version of
iso-scan, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 868859@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christian Perrier <bubulle@debian.org> (supplier of updated iso-scan package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 11 Dec 2017 07:41:56 +0100
Source: iso-scan
Binary: iso-scan load-iso
Architecture: source
Version: 1.61
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Christian Perrier <bubulle@debian.org>
Description:
 iso-scan   - Scan hard drives for an installer ISO image (udeb)
 load-iso   - Load installer components from an installer ISO (udeb)
Closes: 868859 868900
Changes:
 iso-scan (1.61) unstable; urgency=medium
 .
   [ Raphaël Hertzog ]
   * Detect LVM logical volumes so that they can be used to find the ISO image
     that we are looking for. Closes: #868859
   * Copy the ISO image into RAM before mounting it when debconf question
     iso-scan/copy_iso_to_ram is true. This makes it possible to use the disk
     that provided the ISO image for (automatic) partitioning. Closes: #868900
 .
   [ Updated translations ]
   * Bulgarian (bg.po) by Damyan Ivanov
   * Czech (cs.po) by Miroslav Kure
   * German (de.po) by Holger Wansing
   * Estonian (et.po) by Kristjan Räts
   * French (fr.po) by Christian Perrier
   * Hungarian (hu.po) by Dr. Nagy Elemér Károly
   * Lithuanian (lt.po) by Rimas Kudelis
   * Portuguese (Brazil) (pt_BR.po) by Adriano Rafael Gomes
   * Portuguese (pt.po) by Miguel Figueiredo
   * Swedish (sv.po) by Anders Jonsson
Checksums-Sha1:
 27ab25a850b8877575c5ed13407ab765ac26c8e0 1670 iso-scan_1.61.dsc
 555f3e6aebb221341d3a61a4e7b782a82c79c611 105728 iso-scan_1.61.tar.xz
Checksums-Sha256:
 3724f932be280152a0f0a8ac698af4e6d5aafa1bbaf2a0252758925e5bb4c4e4 1670 iso-scan_1.61.dsc
 6ee664608907e07475cc5c0c162499d350951c1da5b2312843555bca1a2f3e3c 105728 iso-scan_1.61.tar.xz
Files:
 65eab398be1b81d3359b05021cdc3597 1670 debian-installer optional iso-scan_1.61.dsc
 679b5aef3d7f5848a5606a2c1c2373fe 105728 debian-installer optional iso-scan_1.61.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE1cL5v8oSi7oip3IYhy9wLE1uJagFAlouKokACgkQhy9wLE1u
JaiOpw//Up8/6/yi6eJ6vExxcwbJol+xmYAnTJeNrXQ4uE7sni4jkxYYDXWDx98B
6WHrdMJMp/jrqH5jzuK5O2PzUencrL/TV2SImeQBCqBjJamDtqsYl3WMJw5Fpwid
ginhv5Qvl9QWHTKeZ60Y2jrf54RnoVdIamnsUjh6jd7uVu+5OcajsGiowo8K8V8L
NX78hSmNE7mpluh2X3JaE+Jv8JXWnfn3AKyNAY0XFM92VWLptGyLyecNc9Tzd39H
rg/Okq2W8ikQInhkDLZorxFrxEnaSkhQnVtY/V/1VQCpIjdnbHdSNnq7kR/h4dsV
Nxe4K5pI6A+rLbhi/bMW/eHEcIQwHUgHunoJTB4nvin6+q1G5LsrH4I4YAyd7icr
rWUbqjM5UIQ5u69y6yAoYX+5/msEFPuFNddydrnsYrFTa21h4YJes+nTME1qOf4h
TMjIgjC/myEj47uBxLpUpXgL3GswoBpNHtDkJEHaVP0oJOyk43X3Ibt9oWouPVNE
zeRjpc2aAUqGSerRthFwf+4jETO2wjNqRVy0btXsF9jP7lhT6RJ3u+LXBBHMvbp4
1SOuztJ3NVMFzQLWM12ge/a17swTdAVRvymYiab57WHYs7qLqpBIh1j/f0NDUU4A
I25U9apwXezCwllpwjEm+1AR1tINH2dQmit264M6QxTxmuXQL7k=
=ISmm
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: