Bug#874474: marked as done (Not easy to rebuild KeyboardNames.pl on its own)
Your message dated Wed, 6 Sep 2017 16:56:30 +0300
with message-id <20170906135630.GF8248@logic>
and subject line Re: Bug#874474: Not easy to rebuild KeyboardNames.pl on its own
has caused the Debian Bug report #874474,
regarding Not easy to rebuild KeyboardNames.pl on its own
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)
--
874474: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=874474
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: console-setup
Version: 1.166
Severity: normal
Tags: patch
Hi there,
In Ubuntu's installer (ubiquity), we want to generate KeyboardNames.pl.
We do so in approximately this way:
$ make -C d-i/source/console-setup/Keyboard KeyboardNames.pl
Unfortunately this stopped working once we got a release that included
739ea571984c140fa7e2e5b5b12a9b8f8ca77992. This included the change:
-KeyboardNames.pl:
- ./xmlreader $(xkbdir)/rules/xorg.xml >KeyboardNames.pl
+$./KeyboardNames.pl:
+ $(kbddir)/xmlreader $(xkbdir)/rules/xorg.xml >$@
Now we get:
root@probable-ewe:~/console-setup/Keyboard# rm KeyboardNames.pl
root@probable-ewe:~/console-setup/Keyboard# make KeyboardNames.pl
make: *** No rule to make target 'KeyboardNames.pl'. Stop.
When trying to make the file. Is there an invocation we can use to generate the
file? Otherwise, what about including a change like:
diff --git a/Keyboard/Makefile b/Keyboard/Makefile
index 08c9fef..ee12d96 100644
--- a/Keyboard/Makefile
+++ b/Keyboard/Makefile
@@ -82,5 +82,5 @@ maintainer-clean .PHONY : $~maintainer-clean
$~maintainer-clean: $~clean
cd $(kbddir) && ./xmlreader >KeyboardNames.pl
-$./KeyboardNames.pl:
+KeyboardNames.pl $./KeyboardNames.pl:
$(kbddir)/xmlreader $(xkbdir)/rules/xorg.xml >$@
please?
Cheers,
--
Iain Lane [ iain@orangesquash.org.uk ]
Debian Developer [ laney@debian.org ]
Ubuntu Developer [ laney@ubuntu.com ]
--- End Message ---
--- Begin Message ---
On Wed, Sep 06, 2017 at 12:19:07PM +0100, Iain Lane wrote:
>
> In Ubuntu's installer (ubiquity), we want to generate KeyboardNames.pl.
> We do so in approximately this way:
>
> $ make -C d-i/source/console-setup/Keyboard KeyboardNames.pl
> Unfortunately this stopped working once we got a release that included
> 739ea571984c140fa7e2e5b5b12a9b8f8ca77992.
>
> Is there an invocation we can use to generate the file?
What about the following:
$ make -C d-i/source/console-setup/Keyboard $(pwd)/d-i/source/console-setup/Keyboard/KeyboardNames.pl
The full path is required because of the following. I found that it is
very difficult to guarantee that a parallel build of console-setup with
recursive make invocations is bug-free. Therefore console-setup no
longer uses recursive makefiles but includes all makefiles into one huge
Makefile. In order to guarantee that no target collisions will appear,
the targets include the full path.
You will find more info at the following links:
http://aegis.sourceforge.net/auug97.pdf
https://mischasan.wordpress.com/2013/03/30/non-recursive-make-gmake-part-1-the-basic-gnumakefile-layouts/
Anton Zinoviev
--- End Message ---
Reply to: