Re: [PATCH] Cope with more unset/disabled root password options
On Sun, Jul 09, 2017 at 02:52:14PM +0100, Colin Watson wrote:
>On Fri, Jul 07, 2017 at 04:20:10PM +0100, Steve McIntyre wrote:
>> Recognise and cope with a different *disabled* root password ("!*") in
>> /etc/shadow as well as the normal unset one ("*"). Closes: #866206,
>> fixing a major bug in the live installer.
>
>Looks good to me, though at this point it might be worth refactoring
>that conditional a bit to assign the grep output to a local variable to
>avoid the repeated subprocess invocations.
Nod. I pondered that, but for this patch thought I'd keep the core
code the same to make reviewing easier.
--
Steve McIntyre, Cambridge, UK. steve@einval.com
Welcome my son, welcome to the machine.
Reply to: