[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#853990: Acknowledgement (Add prompt for iSCSI initiator name in installer)

Kevin Otte <nivex@nivex.net> writes:

>> which I've just rebased and then tweaked to use a here document:
>>   https://anonscm.debian.org/cgit/d-i/partman-iscsi.git/log/?h=pu/iscsi-initiator-prompt
> The here document needs to be left justified, lest the target file end
> up with the indentation. See finish.d/iscsi_settings:69 et al.

I'm always torn on this one.

I like pretty code, so I used <<- (which strips out leading TABs from
the here doc) so it will actually do the right thing as it is now.

However, it only takes someone that doesn't know about that subtlety to
carelessly edit the file and turn TABs into spaces to break things and
create a hard to notice bug, so perhaps I should have left the '-' and
the TABs out, as you suggest.

Cheers, Phil.
|)|  Philip Hands  [+44 (0)20 8530 9560]  HANDS.COM Ltd.
|-|  http://www.hands.com/    http://ftp.uk.debian.org/
|(|  Hugo-Klemm-Strasse 34,   21075 Hamburg,    GERMANY

Attachment: signature.asc
Description: PGP signature

Reply to: