[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#821249: marked as done (debian-installer: may ignore mkinitramfs failure)



Your message dated Mon, 16 May 2016 22:20:20 +0000
with message-id <E1b2Qs8-0005im-Gq@franck.debian.org>
and subject line Bug#821249: fixed in debian-installer 20160516
has caused the Debian Bug report #821249,
regarding debian-installer: may ignore mkinitramfs failure
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
821249: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=821249
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: src:debian-installer
Version: 20160112
Severity: important
Tags: patch pending
User: debian-bsd@lists.debian.org
Usertags: kfreebsd

Hi,

d-i daily builds of kfreebsd-amd64 started to have problems
beginning with:
https://d-i.debian.org/daily-images/kfreebsd-amd64/20160406-00:06/build_netboot-gtk-10.log

When makefs created the initramfs, it had an error, but left a
broken/truncated output file.  Within the case statement, an error there
is ignored and gzip will try to compress the output file.  If that
succeeds, it returns a success status to make, and the build
continues...

This could affect linux too.  A patch is attached;  I'll commit it as
soon as the BTS gives me a bug number.  Thanks!

| case ufs1 in \
| ext2) \
| 	  genext2fs -d ./tmp/netboot-gtk-10/tree -b `expr $(du -s ./tmp/netboot-gtk-10/tree | cut -f 1) + $(expr $(find ./tmp/netboot-gtk-10/tree | wc -l) \* 2)` -m 0 ./tmp/netboot-gtk-10/initrd; \
| 	  e2fsck -fy ./tmp/netboot-gtk-10/initrd || true; \
| 	gzip -n -v9f ./tmp/netboot-gtk-10/initrd; \
| ;; \
| initramfs) \
| 	  (cd ./tmp/netboot-gtk-10/tree && find . | sort | cpio --quiet -o -H newc) >  ./tmp/netboot-gtk-10/initrd; \
| 	gzip -n -v9f ./tmp/netboot-gtk-10/initrd; \
| ;; \
| jffs2) \
| 	   -d ./tmp/netboot-gtk-10/tree -o ./tmp/netboot-gtk-10/initrd.gz; \
| ;; \
| ufs1) \
| 	  sh -c 'makefs -t ffs -T 1459901061 -s 68m -f 3000 -o minfree=0,version=1 $0 ./tmp/netboot-gtk-10/tree' ./tmp/netboot-gtk-10/initrd; \
| 	gzip -n -v9f ./tmp/netboot-gtk-10/initrd; \
| ;; \
| *) \
| 	echo "Unsupported filesystem type"; \
| 	exit 1 ;; \
| esac
| Calculated size of `./tmp/netboot-gtk-10/initrd': 71303168 bytes, 4595 inodes
| Extent size set to 8192
| ./tmp/netboot-gtk-10/initrd: 68.0MB (139264 sectors) block size 8192, fragment size 1024
| 	using 2 cylinder groups of 52.26MB, 6689 blks, 3584 inodes.
| super-block backups (for fsck -b #) at:
|      32, 107056,makefs: Writing inode 1578 (./tmp/netboot-gtk-10/tree/sbin/devd), bytes 188416 + 8192: No space left on device
| 
| Populating `./tmp/netboot-gtk-10/initrd'
| ./tmp/netboot-gtk-10/initrd:	 61.6% -- replaced with ./tmp/netboot-gtk-10/initrd.gz

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: kfreebsd-amd64 (x86_64)

Kernel: kFreeBSD 10.1-0-amd64
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
>From 93af24652f09144720d730a8de7f0e5e574c9947 Mon Sep 17 00:00:00 2001
From: Steven Chamberlain <steven@pyro.eu.org>
Date: Sun, 17 Apr 2016 00:09:33 +0100
Subject: [PATCH] Handle error creating initramfs (Closes: #xxxxxx)

The case statement returns only the last-executed command's status,
potentially ignoring errors creating the initramfs.  Use `set -e` so
that any error is returned immediately to make.
---
 build/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/build/Makefile b/build/Makefile
index ec1953b..cff44e0 100644
--- a/build/Makefile
+++ b/build/Makefile
@@ -707,6 +707,7 @@ endif
 
 	install -d $(TEMP)
 
+	set -e; \
 	case $(INITRD_FS) in \
 	ext2) \
 		$(genext2fs) $(TEMP)/initrd; \
-- 
1.8.4.rc3


--- End Message ---
--- Begin Message ---
Source: debian-installer
Source-Version: 20160516

We believe that the bug you reported is fixed in the latest version of
debian-installer, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 821249@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Cyril Brulebois <kibi@debian.org> (supplier of updated debian-installer package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Mon, 16 May 2016 15:00:21 +0200
Source: debian-installer
Binary: debian-installer
Architecture: source
Version: 20160516
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Cyril Brulebois <kibi@debian.org>
Description:
 debian-installer - Debian Installer documentation
Closes: 817073 821249
Changes:
 debian-installer (20160516) unstable; urgency=low
 .
   [ Martin Michlmayr ]
   * Provide u-boot images for OpenRD.
   * Remove mipsel/bcm947xx config file.
   * Use gpgv1.4-udeb for orion5x network-console so the ramdisk fits
     in flash on QNAP TS-x09 devices.
   * Update QNAP TS-x09 kernel address to the new value used by
     flash-kernel (see #809476).
   * Bump Linux kernel version from 4.3.0-1 to 4.4.0-1
   * Use new marvell kernel flavour for orion5x and kirkwood
   * Include mtd-modules in kirkwood images.
   * Include mtd-modules in armhf netboot images.
   * Provide kernel and ramdisk for kirkwood netboot.
   * Fix syntax error in doc internals build script.  Thanks to
     Josh Gadeken (Closes: #817073)
   * Add kernel/initrd manifest information for armhf.
   * Generate image for Seagate Personal Cloud and Seagate NAS.
 .
   [ Samuel Thibault ]
   * config/hurd.cfg: Set ROOTCMD to fakeroot-tcp.
   * hurd: Use exec.static instead of ld.so to start exec. This avoids libc
     version synchronization issues.
 .
   [ Colin Watson ]
   * Use HTTPS for Vcs-* URLs, and link to cgit rather than gitweb.
 .
   [ Roger Shimizu ]
   * ARM: orion5x: Fix typo in lspro-config-debian script
   * ARM: orion5x: add device tree support for armel/orion5x
   * ARM: add/update a few Buffalo Linkstation support on
     armel/orion5x
       - Linkstation LS-WTGL
       - Linkstation Mini (LS-WSGL)
       - Linkstation Pro/Live (LS-GL)
     armel/kirkwood
       - Linkstation LS-QVL
       - Linkstation LS-VL
       - Linkstation LS-WSXL
       - Linkstation LS-WVL
       - Linkstation LS-WXL
   * ARM: update kernel/initrd address for various Buffalo Linkstation
     to be consistent with flash-kernel
   * ARM: orion5x: share (symbolic link) the initrd for all Linkstation series
   * ARM: orion5x: unify model name of Linkstation with kirkwood based ones
   * ARM: orion5x: rename lspro-config-debian script to
     linkstation-config-debian
   * ARM: kirkwood: apply linkstation-config-debian script to all Linkstation
     devices
 .
   [ Vagrant Cascadian ]
   * Add support for Firefly-RK3288.
   * Add u-boot-rockchip to the "built-using" package list.
   * Add support for BeagleBoard-X15.
 .
   [ Karsten Merker ]
   * ARM: sunxi: Add support for the Olimex A20-SOM-EVB.
 .
   [ Adam Conrad ]
   * Drop references to libnss-files-udeb and libnss-dns-udeb, they're now
     provided by libc-udeb, as of glibc 2.22-5.
 .
   [ Aurelien Jarno ]
   * Stop excluding libc{0.1,0.3,6,6.1} as we now use mklibs-copy for the
     reduction pass. This avoids dropping libnss libraries and also avoids a
     useless download of this udeb during the installation.
   * Drop build-dependency on glibc-pic.
   * armhf: drop the compat ld.so symlink, all binaries in testing now use the
     correct one.
 .
   [ Cyril Brulebois ]
   * Bump Linux kernel version from 4.4.0-1 to 4.5.0-2
   * efi-image: Make the mkfs.msdos call verbose; this might help track
     regressions or strange behaviours with new dosfstools upstream
     releases (See: #823881).
   * gen-hd-image: Make the mkfs.msdos call verbose.
   * x86.cfg: Make the mkfs.msdos call verbose.
   * build/Makefile: Export MTOOLS_SKIP_CHECK=1 before running mmd and
     mcopy commands to work around an apparent regression in dosfstools
     4.0-1 (See: #823881). Confirmed by Steve to produce an image that
     boots OK.
   * Update translation-status for the release.
 .
   [ Steven Chamberlain ]
   * Handle error creating initramfs (Closes: #821249)
   * Increase kfreebsd-amd64 MFSROOT to 72 MiB to allow for larger udebs
Checksums-Sha1:
 979649b920e2aacf246882b8ae4709421b558202 3517 debian-installer_20160516.dsc
 38413b88ee812f52c29f8737e317a774767ef3d3 1378907 debian-installer_20160516.tar.gz
Checksums-Sha256:
 a29b0f650883fde4598cf499ad7a3fb1fe0c1a8223c8f191a787d5dc94cb797d 3517 debian-installer_20160516.dsc
 5a5ccbf3bd98ddf680592aed9ff21b29c7eab7ed5b306ecd6440e786cab08aa3 1378907 debian-installer_20160516.tar.gz
Files:
 44e07fb6c714385a02e7e5b454f3a7a2 3517 devel optional debian-installer_20160516.dsc
 df2f8084fb8d79b848d538f9440a7370 1378907 devel optional debian-installer_20160516.tar.gz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJXOjD0AAoJEP+RSvDCs1Ug0VsP/0hOCfpAR8QsHB3O1YbBnFxb
GT03raGAxBOoQTBSWG9qtYlfjDaouKQhXayK7/UpnM7DlmxtFB+nWlqmWsp6Em5s
ouzKo/6oCwb0ozDSkeZEuMAkyBaf25CE9ddob72vRqqw5c9AzBityrbZOC7gKyTX
gLqihkKBO4vtdSdiCKfrvwrHonpv3GEo/WTVMyzRBrFH8jI6ytVz4nPaqWhxG0Tc
ekpG9yOTtOpDa52wtsiVVZ4LpZGFrRUlLcypow9W6wRsFeZ6Ku0W6fAWtR+SsQ3O
WHpfQxfmHTJvvHv1CB117DYUSVZvgFfBcnlh0tAcCNsXU+VWsYG3iVgWFF8MViGm
DjMy6yTpcGqJobrmPkz7emsuaPIT+2/pE8EYojEksqIW0yd69NWavlWaNClhDXdL
HfQVkPQRjSJvvCXNruHqO4XihSygAGB7gNiwjaBG4CWTrAq6+YBr5Qi9zSXK6IqQ
6jDZdi16/0b06GIeLySnpLkbKsa8xmTzc5CO7OlXRjNzNROfEpbdGN2rconWqyrz
K37+Zx4grepZDCIWewoJBkco1XSpAxu7FfBpMiGh7PZHMZr09hN6HAMXkJuAAhxk
KsBT1rqMwDicbnOTDarL3M7M1o3oKlAHWPPuFaWcWyqOiZ4lRFqKqsz82p/xQEh8
Qx+95oJ6CNFmUglrAoxi
=xhpq
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: